[Openvpn-devel] [M] Change in openvpn[master]: Install host routes for ifconfig-push routes when DCO is enabled

[plaisthos (C. Review) <ge...@op...>]

Attention is currently required from: cron2, flichtenheld, ordex.

plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email )

Change subject: Install host routes for ifconfig-push routes when DCO is enabled
......................................................................


Patch Set 8:

(5 comments)

Patchset:

PS8: 
> this got broken during review / respin... […]
Yeah not really sure what happend there during my rebase. I am going through the patch again to see that it really works.


File src/openvpn/dco.c:

http://gerrit.openvpn.net/c/openvpn/+/1192/comment/1d9fd552_43ebda64?usp=email :
PS8, Line 686: 
> This got broken in patch iterations - initially everything was `MR_ONLINK_ADDR` and then the define  […]
Acknowledged


http://gerrit.openvpn.net/c/openvpn/+/1192/comment/394a8910_234e7857?usp=email :
PS8, Line 700:         if (addr->type & MR_ONLINK_ADDR)
> _DCO_
Done


http://gerrit.openvpn.net/c/openvpn/+/1192/comment/d3123254_400e84c7?usp=email :
PS8, Line 745:         }
> this looks wrong. […]
Done


http://gerrit.openvpn.net/c/openvpn/+/1192/comment/fba68590_cdaa0d71?usp=email :
PS8, Line 771:         }
> This is asymmetric to IPv4 - I guess this is from early tests, and the `dco_win_del... […]
Acknowledged



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I83295e00d1a756dfa44050b0a4493095fb050fff
Gerrit-Change-Number: 1192
Gerrit-PatchSet: 8
Gerrit-Owner: plaisthos <arn...@rf...>
Gerrit-Reviewer: cron2 <ge...@gr...>
Gerrit-Reviewer: d12fk <he...@op...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: ordex <an...@ma...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: cron2 <ge...@gr...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-Attention: ordex <an...@ma...>
Gerrit-Comment-Date: Mon, 13 Oct 2025 14:23:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <ge...@gr...>