[Openvpn-devel] [M] Change in openvpn[master]: Install host routes for ifconfig-push routes when DCO is enabled

[cron2 (C. Review) <ge...@op...>]

Attention is currently required from: flichtenheld, ordex, plaisthos.

cron2 has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email )

Change subject: Install host routes for ifconfig-push routes when DCO is enabled
......................................................................


Patch Set 8:

(1 comment)

Patchset:

PS8: 
Ah, it compiles because that particular test instance had `configure --disable-dco`.  If configured without that, compilation bombs in the expected way

```
  CC       dco.o
dco.c: In function 'dco_install_iroute':
dco.c:683:26: error: 'MR_ONLINK_ADDR' undeclared (first use in this function); did you mean 'MR_ONLINK_DCO_ADDR'?
  683 |         if (addr->type & MR_ONLINK_ADDR)
      |                          ^~~~~~~~~~~~~~
      |                          MR_ONLINK_DCO_ADDR
dco.c:683:26: note: each undeclared identifier is reported only once for each function it appears in
dco.c: In function 'dco_delete_iroutes':
dco.c:744:13: error: implicit declaration of function 'dco_win_del_iroute_ipv4' [-Wimplicit-function-declaration]
  744 |             dco_win_del_iroute_ipv4(&c->c1.tuntap->dco, mi->context.c2.push_ifconfig_local, 32);
      |             ^~~~~~~~~~~~~~~~~~~~~~~
```



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I83295e00d1a756dfa44050b0a4493095fb050fff
Gerrit-Change-Number: 1192
Gerrit-PatchSet: 8
Gerrit-Owner: plaisthos <arn...@rf...>
Gerrit-Reviewer: cron2 <ge...@gr...>
Gerrit-Reviewer: d12fk <he...@op...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: ordex <an...@ma...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-Attention: ordex <an...@ma...>
Gerrit-Comment-Date: Sun, 12 Oct 2025 12:59:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No