[Openvpn-devel] [M] Change in openvpn[master]: platform: Do not assume uid_t/gid_t are signed

[MaxF (C. Review) <ge...@op...>]

Attention is currently required from: flichtenheld, plaisthos.

MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1206?usp=email )

Change subject: platform: Do not assume uid_t/gid_t are signed
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

File src/openvpn/platform.c:

http://gerrit.openvpn.net/c/openvpn/+/1206/comment/cfa9da6d_0cb4d448 :
PS2, Line 87:         if (!pw)
            :         {
            :             msg(M_ERR, "failed to find UID for user %s", username);
            :         }
> Note the CLEAR() at the top of the function
Oops, you're right!


http://gerrit.openvpn.net/c/openvpn/+/1206/comment/65848078_10dc0c02 :
PS2, Line 131:         if (!gr)
             :         {
             :             msg(M_ERR, "failed to find GID for group %s", groupname);
             :         }
> Note the CLEAR() at the top of the function
Done



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1206?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie6b4c41d13544d5ba71d441cc794c7abd12408f3
Gerrit-Change-Number: 1206
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <fr...@li...>
Gerrit-Reviewer: MaxF <ma...@ma...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-Comment-Date: Fri, 26 Sep 2025 16:16:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: flichtenheld <fr...@li...>
Comment-In-Reply-To: MaxF <ma...@ma...>
Gerrit-MessageType: comment