[Openvpn-devel] [S] Change in openvpn[master]: crypto_epoch: Clean up type handling in ovpn_expand_label()

[MaxF (C. Review) <ge...@op...>]

Attention is currently required from: flichtenheld, plaisthos.

MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1218?usp=email )

Change subject: crypto_epoch: Clean up type handling in ovpn_expand_label()
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Patchset:

PS1: 
One complaint, the rest looks good!


File src/openvpn/crypto_epoch.c:

http://gerrit.openvpn.net/c/openvpn/+/1218/comment/8a0fb279_f00e51d9 :
PS1, Line 87:     ASSERT(out_len <= UINT16_MAX);
We should also check that out_len >= 0.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1218?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iad717f0ff3c79ae199c8be5f93bc51bf258c68c3
Gerrit-Change-Number: 1218
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <fr...@li...>
Gerrit-Reviewer: MaxF <ma...@ma...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-Comment-Date: Fri, 26 Sep 2025 16:09:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment