[Openvpn-devel] [S] Change in openvpn[master]: crypto: Make some casts to int explicit

[MaxF (C. Review) <ge...@op...>]

Attention is currently required from: flichtenheld, plaisthos.

MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1217?usp=email )

Change subject: crypto: Make some casts to int explicit
......................................................................


Patch Set 1:

(1 comment)

File src/openvpn/crypto.c:

http://gerrit.openvpn.net/c/openvpn/+/1217/comment/8d9d8626_7fe8921d :
PS1, Line 1376:         size = (int)(strlen(file) + 1);
You say that there are limits imposed so that this is safe, but I can't find where that happens. I've looked at options.c and I don't see any limits on the length of tls_crypt_file for example.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1217?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3b8dd8d5671e31dba2a23a0a78f36d9dda034b88
Gerrit-Change-Number: 1217
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: MaxF <ma...@ma...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-Comment-Date: Fri, 26 Sep 2025 15:57:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment