[Openvpn-devel] [M] Change in openvpn[master]: Install host routes with onlink scope iroutes for ifconfig-push routes

[ordex (C. Review) <ge...@op...>]

Attention is currently required from: d12fk, flichtenheld, plaisthos.

ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email )

Change subject: Install host routes with onlink scope iroutes for ifconfig-push routes
......................................................................


Patch Set 4:

(3 comments)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/1192/comment/e68f700d_fb964762 :
PS4, Line 7: Install host routes with onlink scope iroutes for ifconfig-push routes
> I tried to make it a bit easier to understand what is happening here.
how about:

DCO: install onlink host iroute when pushed IP is out of server network

?


http://gerrit.openvpn.net/c/openvpn/+/1192/comment/e81bb1a9_d227e995 :
PS4, Line 10: of the configured device need to be added to the operating system to
> ifconfig-push can be used for both. […]
I agree with that, but what I meant in my comment is that we "need *routes* to be added" not IPs.
In your text you're implying we need to add IPs "..to the operating system.."


File doc/man-sections/server-options.rst:

http://gerrit.openvpn.net/c/openvpn/+/1192/comment/c74c5864_8023ffde :
PS2, Line 317:   When DCO is enabled, OpenVPN will install a /32 route for the local IP
> I already documented. You seem to have commented on version 2 after I uploaded v4.
Done



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I83295e00d1a756dfa44050b0a4493095fb050fff
Gerrit-Change-Number: 1192
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <arn...@rf...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: ordex <an...@ma...>
Gerrit-CC: d12fk <he...@op...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-Attention: d12fk <he...@op...>
Gerrit-Comment-Date: Wed, 17 Sep 2025 11:01:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <arn...@rf...>
Comment-In-Reply-To: ordex <an...@ma...>
Comment-In-Reply-To: d12fk <he...@op...>
Gerrit-MessageType: comment