[Openvpn-devel] [S] Change in openvpn[release/2.6]: dco linux: avoid redefining ovpn enums (2.6)

[ordex (C. Review) <ge...@op...>]

Attention is currently required from: flichtenheld, plaisthos, ralf_lici.

ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1122?usp=email )

Change subject: dco linux: avoid redefining ovpn enums (2.6)
......................................................................


Patch Set 1:

(1 comment)

File src/openvpn/dco_linux.h:

http://gerrit.openvpn.net/c/openvpn/+/1122/comment/5affea11_fc2bbcdc :
PS1, Line 32: #include "ovpn_dco_linux.h"
should we add a comment here that instructs to keep this include always last? (and maybe explain why?)



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1122?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: I41c5dfc7489352a9534ff6b1585a5a81e0623ab1
Gerrit-Change-Number: 1122
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <fr...@li...>
Gerrit-Reviewer: ordex <an...@ma...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-Reviewer: ralf_lici <ra...@ma...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-Attention: ralf_lici <ra...@ma...>
Gerrit-Comment-Date: Thu, 31 Jul 2025 21:02:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment