[Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Added update_option() function.

[mrbff (C. Review) <ge...@op...>]

Attention is currently required from: cron2, flichtenheld, plaisthos, stipa.

mrbff has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/810?usp=email )

Change subject: PUSH_UPDATE: Added update_option() function.
......................................................................


Patch Set 22:

(3 comments)

File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/810/comment/edf64e35_8ed4afac :
PS21, Line 5897:             }
> I find this duplication of syntax checking, mmmh, sub-optimal. […]
idk, i thought it were nice to make some checks before deleting the options. :)


http://gerrit.openvpn.net/c/openvpn/+/810/comment/6c0edd1d_f8769a03 :
PS21, Line 5927:             }
> same here
Done


http://gerrit.openvpn.net/c/openvpn/+/810/comment/af06b38c_73d23b39 :
PS21, Line 6009: 
> same here... lots of code that needs to be in sync with the add_option() checks...
Done



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/810?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia45c99e6df7b3ad24020c10b8a9b3577984ecdc2
Gerrit-Change-Number: 810
Gerrit-PatchSet: 22
Gerrit-Owner: mrbff <ma...@ma...>
Gerrit-Reviewer: cron2 <ge...@gr...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-Reviewer: stipa <lst...@gm...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: cron2 <ge...@gr...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-Attention: stipa <lst...@gm...>
Gerrit-Comment-Date: Wed, 23 Jul 2025 17:12:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <ge...@gr...>
Gerrit-MessageType: comment