From: cron2 (C. Review) <ge...@op...> - 2025-07-23 06:07:36
|
Attention is currently required from: flichtenheld, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1098?usp=email ) Change subject: dco_linux: rearrange functions ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: I have quite a dislike for "move functions around" patches, as they break "git blame" and thus cause future extra work... this one could have been addressed by moving `ovpn_handle_msg()` *down* (which gets rewritten anyway). But anyway. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1098?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I94004579aef4a1ccccdbcf8edd7b722e5a611c72 Gerrit-Change-Number: 1098 Gerrit-PatchSet: 2 Gerrit-Owner: ordex <an...@ma...> Gerrit-Reviewer: cron2 <ge...@gr...> Gerrit-Reviewer: flichtenheld <fr...@li...> Gerrit-Reviewer: plaisthos <arn...@rf...> Gerrit-CC: openvpn-devel <ope...@li...> Gerrit-Attention: plaisthos <arn...@rf...> Gerrit-Attention: flichtenheld <fr...@li...> Gerrit-Attention: ordex <an...@ma...> Gerrit-Comment-Date: Wed, 23 Jul 2025 06:07:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment |