[Openvpn-devel] [M] Change in openvpn[master]: dco: Add support for float notifications

[stipa (C. Review) <ge...@op...>]

Attention is currently required from: flichtenheld, ordex, plaisthos, ralf_lici.

stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1084?usp=email )

Change subject: dco: Add support for float notifications
......................................................................


Patch Set 1:

(1 comment)

File src/openvpn/multi.c:

http://gerrit.openvpn.net/c/openvpn/+/1084/comment/32317b9e_d8a2c183 :
PS1, Line 3390:             if (extract_dco_float_peer_addr(peer_id, &m->top.c2.from.dest,
> Yeah I would trust the kernel on Windows and add an assert to dco_handle_overlapped_success(). […]
after discussion on IRC we decided just to remove this "if" and not to add an assert - we'll get a error later in an improbable cause if dco-win returns invalid AF.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1084?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I33e9272b4196c7634db2fb33a75ae4261660867f
Gerrit-Change-Number: 1084
Gerrit-PatchSet: 1
Gerrit-Owner: ralf_lici <ra...@ma...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: ordex <an...@ma...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-CC: stipa <lst...@gm...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-Attention: ordex <an...@ma...>
Gerrit-Attention: ralf_lici <ra...@ma...>
Gerrit-Comment-Date: Wed, 16 Jul 2025 08:31:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ordex <an...@ma...>
Comment-In-Reply-To: ralf_lici <ra...@ma...>
Comment-In-Reply-To: stipa <lst...@gm...>
Gerrit-MessageType: comment