[Openvpn-devel] [M] Change in openvpn[master]: dco: Add support for float notifications

[ordex (C. Review) <ge...@op...>]

Attention is currently required from: flichtenheld, plaisthos, ralf_lici, stipa.

ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1084?usp=email )

Change subject: dco: Add support for float notifications
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

Patchset:

PS1: 
looks good to me


File src/openvpn/multi.c:

http://gerrit.openvpn.net/c/openvpn/+/1084/comment/febbeba3_6cfc1fdf :
PS1, Line 3390:             if (extract_dco_float_peer_addr(peer_id, &m->top.c2.from.dest,
> Do we really need this "if"? Could we trust the kernel and just assert inside `extract_dco_float_pee […]
no, we can't trust the kernel. when talking to an external component we can't just assume it will always do the right thing. A bug in the kernel code should not crash userspace.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1084?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I33e9272b4196c7634db2fb33a75ae4261660867f
Gerrit-Change-Number: 1084
Gerrit-PatchSet: 1
Gerrit-Owner: ralf_lici <ra...@ma...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: ordex <an...@ma...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-CC: stipa <lst...@gm...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-Attention: ralf_lici <ra...@ma...>
Gerrit-Attention: stipa <lst...@gm...>
Gerrit-Comment-Date: Tue, 15 Jul 2025 14:23:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: stipa <lst...@gm...>
Gerrit-MessageType: comment