[Openvpn-devel] [S] Change in openvpn[master]: Do not check for pkcs11-helper when pkcs11 is not enabled

[plaisthos (C. Review) <ge...@op...>]

Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1085?usp=email )

Change subject: Do not check for pkcs11-helper when pkcs11 is not enabled
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
> We should dig deeper. […]
This is not limited to mbed TLS. 

The test ldflags/cflags will also automatically add the PKCS11 LIBS/CFLAG flags if they are present.

TEST_LDFLAGS="${OPTIONAL_CRYPTO_LIBS} ${OPTIONAL_PKCS11_HELPER_LIBS} ${OPTIONAL_LIBCAPNG_LIBS}"
TEST_CFLAGS="${OPTIONAL_CRYPTO_CFLAGS} ${OPTIONAL_PKCS11_HELPER_CFLAGS} ${OPTIONAL_LIBCAPNG_CFLAGS}"

It felt easier to just not do the pkg config check and define the variables then do an if/fi around all the other uses.

For mbed + pkcs11, see this commit: https://github.com/openvpn/openvpn/commit/9a3f670248d6f519a399e65a7232e2196b5115db



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1085?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I152577b7d9b3b3a0d298971f47ba412d3f43d50d
Gerrit-Change-Number: 1085
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arn...@rf...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-Comment-Date: Mon, 14 Jul 2025 12:48:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <fr...@li...>
Gerrit-MessageType: comment