[Openvpn-devel] [PATCH applied] Re: dns: deal with --dhcp-options when --dns is active

[Gert D. <ge...@gr...>]

So - finally the Grand DNS Rewrite is reaching the final commits - thanks
Heiko for all the work.

This patch brings working --dns-updown for configs where the server still
pushes "dhcp-options DNS" - and vice versa, compat "foreign_option..."
settings in --up for configs where the server pushes "--dns ..."

Windows will see DNS via iservice "but not if TAP + DHCP is active"
(compat again).

Lev has tested the various windows variants, I have tested all the
"incoming" variants (reference server can push this or that, depending
on client requests) and verified that --dns-updown applies whatever
makes sense, and alternatively "--up printenv.sh" will show the correct
DNS options.

There might be bugs lurking, but overall this does what it aims for, and
the code looks good (I stared at it quite a bit over the last months ;-) ).

NOTE: Android has not explicitely been tested, but given that it shares
the "tuntap" option handling with Windows, I expect nothing to break there.

Your patch has been applied to the master branch.

commit 2dfc4f82792b197dfa47d2bfe32c2af66b329611
Author: Heiko Hund
Date:   Wed Jun 18 14:48:29 2025 +0200

     dns: deal with --dhcp-options when --dns is active

     Signed-off-by: Heiko Hund <he...@is...>
     Acked-by: Gert Doering <ge...@gr...>
     Message-Id: <202...@gr...>
     URL: https://www.mail-archive.com/ope...@li.../msg31922.html
     Signed-off-by: Gert Doering <ge...@gr...>


--
kind regards,

Gert Doering