[Openvpn-devel] [M] Change in openvpn[master]: Added PQE to WolfSSL

[plaisthos (C. Review) <ge...@op...>]

Attention is currently required from: comododragon, flichtenheld.

plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1046?usp=email )

Change subject: Added PQE to WolfSSL
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
You don't need to close/reopen to update your patch, you can just push the change again. But here is the same comment that I had on the original version of the patch:

I feel this is the wrong approach. We are trying to avoid the NID dance. And it seems that wolfSSL already has a function 

int wolfSSL_CTX_set1_groups_list(WOLFSSL_CTX *ctx, const char *list)

that has the same (better) functionality of its SSL_CTX_set1_groups_list OpenSSL equivalent. So rather than doing this NID dance, I would prefer that we use the proper function instead. 

Maybe wolfSSL upstream can also be convinced to map this to SSL_CTX_set1_groups_list as well.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1046?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie0529c2074964b3be034f01e0ef53090a6edbd35
Gerrit-Change-Number: 1046
Gerrit-PatchSet: 1
Gerrit-Owner: comododragon <rei...@fo...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-Attention: comododragon <rei...@fo...>
Gerrit-Comment-Date: Wed, 18 Jun 2025 09:12:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment