[Openvpn-devel] [XL] Change in openvpn[master]: Reformat the whole project with clang-format

[flichtenheld (C. Review) <ge...@op...>]

Attention is currently required from: cron2, ordex, plaisthos.

flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/791?usp=email )

Change subject: Reformat the whole project with clang-format
......................................................................


Patch Set 18:

(3 comments)

File src/openvpn/buffer.c:

http://gerrit.openvpn.net/c/openvpn/+/791/comment/6892fcb6_41f2daaf :
PS18, Line 850:     } while (c);
> it should not do that
Why?


http://gerrit.openvpn.net/c/openvpn/+/791/comment/18dc39e2_b722d6bf :
PS18, Line 915:             && c != 127)) /* allow ascii non-control and UTF-8, consider DEL to be a control */
> this is ugly, but I guess the best way to fix it is to manually move the comment before the if() lin […]
Yes.


File src/openvpn/console_builtin.c:

http://gerrit.openvpn.net/c/openvpn/+/791/comment/e785d1b2_41139a46 :
PS18, Line 74:         msg(M_WARN | M_ERRNO, "get_console_input_win32(): unexpected error");
> the extra spaces around `foo|bar` are not really to my liking ("this belongs together" vibes)
Interestingly one of the things we can't configure in clang-format. The space around binary operators is not optional.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/791?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2566ad493629e1f5fdfa6f6483b8973463404e3e
Gerrit-Change-Number: 791
Gerrit-PatchSet: 18
Gerrit-Owner: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: cron2 <ge...@gr...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-CC: ordex <an...@ma...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: cron2 <ge...@gr...>
Gerrit-Attention: ordex <an...@ma...>
Gerrit-Comment-Date: Mon, 26 May 2025 09:54:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <ge...@gr...>
Gerrit-MessageType: comment