[Openvpn-devel] [L] Change in openvpn[master]: dns: deal with --dhcp-options when --dns is active

[stipa (C. Review) <ge...@op...>]

Attention is currently required from: d12fk, flichtenheld, plaisthos.

stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/904?usp=email )

Change subject: dns: deal with --dhcp-options when --dns is active
......................................................................


Patch Set 15: Code-Review+1

(2 comments)

Patchset:

PS15: 
Stared at the code and slightly tested on Windows, both --dhcp-option dns and --dns work, in various combinations. I haven't checked env variables and non-Windows parts.

While not the fault of this patch, I noticed that inside run_up_down_service() we do not log success of setting DNS via service, like we normally do when we talk to the service:

  2025-05-01 11:49:09 us=187000 INET address service: add 10.8.0.2/24
  2025-05-01 11:49:09 us=203000 IPv4 MTU set to 1500 on interface 20 using service
  
Let's do that for DNS, too, in a separate patch.


File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/904/comment/dbd3e34f_fbb036f8 :
PS15, Line 4299:         tuntap_options_postprocess_dns(o);
Why WIN32 and Android require special treatment? I see that it was not added in this patch, but still a comment "why" could be in place, since we touch this fragment.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/904?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a
Gerrit-Change-Number: 904
Gerrit-PatchSet: 15
Gerrit-Owner: d12fk <he...@op...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-Reviewer: stipa <lst...@gm...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-Attention: d12fk <he...@op...>
Gerrit-Comment-Date: Thu, 01 May 2025 09:05:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment