[Openvpn-devel] [L] Change in openvpn[master]: dns: deal with --dhcp-options when --dns is active

[d12fk (C. Review) <ge...@op...>]

Attention is currently required from: flichtenheld, plaisthos, stipa.

d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/904?usp=email )

Change subject: dns: deal with --dhcp-options when --dns is active
......................................................................


Patch Set 14:

(2 comments)

File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/904/comment/d8e761d9_4194af85 :
PS14, Line 3504:         memcpy(tt->domain_search_list, dhcp->domain_search_list, sizeof(tt->domain_search_list));
> C:\Users\lev\Projects\openvpn-build\src\openvpn\src\openvpn\options. […]
Done


http://gerrit.openvpn.net/c/openvpn/+/904/comment/842e2bc7_5ade9b3b :
PS14, Line 8350:         }
> is "else" missing here? I have "--dhcp-option DNS 8.8.4. […]
Done



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/904?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a
Gerrit-Change-Number: 904
Gerrit-PatchSet: 14
Gerrit-Owner: d12fk <he...@op...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-Reviewer: stipa <lst...@gm...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-Attention: stipa <lst...@gm...>
Gerrit-Comment-Date: Mon, 28 Apr 2025 06:12:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: stipa <lst...@gm...>
Gerrit-MessageType: comment