[Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Added remove_option() and do_update().

[stipa (C. Review) <ge...@op...>]

Attention is currently required from: flichtenheld, mrbff, plaisthos.

stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/809?usp=email )

Change subject: PUSH_UPDATE: Added remove_option() and do_update().
......................................................................


Patch Set 7: Code-Review-2

(2 comments)

File src/openvpn/init.h:

http://gerrit.openvpn.net/c/openvpn/+/809/comment/94a55af1_56ebeb0e :
PS4, Line 89: bool do_update(struct context *c, unsigned int option_types_found);
Doxygen


File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/809/comment/3765b756_2ab72e4d :
PS7, Line 3300:              && (opt->routes->flags & RG_DEF1))
this gives me "access violation" on Windows, opt->routes is nullptr.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/809?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I507180d7397b6959844a30908010132bc3411067
Gerrit-Change-Number: 809
Gerrit-PatchSet: 7
Gerrit-Owner: mrbff <ma...@ma...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-Reviewer: stipa <lst...@gm...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-Attention: mrbff <ma...@ma...>
Gerrit-Comment-Date: Tue, 03 Dec 2024 14:42:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment