[Openvpn-devel] [M] Change in openvpn[master]: Route: add support for user defined routing table

[its_Giaan (C. Review) <ge...@op...>]

Attention is currently required from: flichtenheld, plaisthos.

its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/524?usp=email )

Change subject: Route: add support for user defined routing table
......................................................................


Patch Set 1:

(2 comments)

Patchset:

PS1: 
What about "Table_id is supported only on Linux when SITNL is built-in" so we know that in case we're on Linux but there's not SITNL -> "SITNL is required", on the other hand if we're not on Linux -> "this is Linux only"


File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/524/comment/d372a561_90367367 :
PS1, Line 6992:         msg(M_WARN, "NOTE: --route-table specified, but not supported on this platform");
> This warning would be confusing with a Linux build with --enable-iproute2. […]
What about "Table_id is supported only on Linux when SITNL is built-in" so we know that in case we're on Linux but there's not SITNL -> "SITNL is required", on the other hand if we're not on Linux -> "this is Linux only"



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/524?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3e4ebef484d2a04a383a65ede5617ee98bf218a7
Gerrit-Change-Number: 524
Gerrit-PatchSet: 1
Gerrit-Owner: its_Giaan <gia...@ma...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-Comment-Date: Tue, 20 Feb 2024 13:33:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <fr...@li...>
Gerrit-MessageType: comment