[Openvpn-devel] [M] Change in openvpn[master]: Route: add support for user defined routing table

[its_Giaan (C. Review) <ge...@op...>]

Attention is currently required from: flichtenheld, plaisthos.

its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/524?usp=email )

Change subject: Route: add support for user defined routing table
......................................................................


Patch Set 1:

(2 comments)

Patchset:

PS1: 
I defined it but not set it to make sure that when retrieving the whitelist of pullable options in pull_permission_mask() the pull were not allowed but rather it printed an options error.


File src/openvpn/options.h:

http://gerrit.openvpn.net/c/openvpn/+/524/comment/81e9279e_e04fe802 :
PS1, Line 745: #define OPT_P_ROUTE_TABLE     (1<<31)
> it is not clear to my why you need a separate permission entry here? Should maybe add a comment abou […]
Acknowledged



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/524?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3e4ebef484d2a04a383a65ede5617ee98bf218a7
Gerrit-Change-Number: 524
Gerrit-PatchSet: 1
Gerrit-Owner: its_Giaan <gia...@ma...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-Comment-Date: Mon, 19 Feb 2024 15:52:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <fr...@li...>
Gerrit-MessageType: comment