Re: [Openvpn-devel] [PATCH 1/9 v3] Indicate that a client is in pull mode in IV_PROTO

[Antonio Q. <a...@un...>]

Hi,

On 21/07/2020 18:38, Arne Schwabe wrote:
> This allows us to skip waiting for the first PUSH_REQUEST message from
> the client to send the response.
> 
> This changes the interpretation of IV_PROTO from a scalar to a bitfield
> Since we only have IV_PROTO=2 defined so far and will support DATA_V2
> this should not make any problem. This avoid adding another IV_xxx variable
> that takes valuable space in the protocol frame.
> 
> Signed-off-by: Arne Schwabe <ar...@rf...>
> 
> Patch V2: Use bitmask for IV_PROTO_DATA_V2 and add more documentation.
> 
> Patch V3: Rewrite IV_PROTO paragraph in man page, incoperate spelling fixes
>           by tincanteksup.
> 
> Signed-off-by: Arne Schwabe <ar...@rf...>


Thanks a lot for all the fixes. Looks good to me now.

-- 
Antonio Quartulli