Re: [Openvpn-devel] [PATCH 3/9] Require AEAD support in the crypto library

[Steffan K. <ste...@fo...>]

Hi,

On 17-07-2020 15:47, Arne Schwabe wrote:
> All supported crypto libraries have AEAD support and with our
> ncp/de facto default cipher AES-256-GCM we do not want to support
> the obscure corner case of a library with disabled AEAD.

Again: feature-ACK, but some comments.

config-msvc.h still has a

  #define HAVE_AEAD_CIPHER_MODES 1

and ssl_openssl.c has two occurances of

  #ifdef EVP_CIPH_FLAG_AEAD_CIPHER

which I think can go too now.

-Steffan