Re: [Openvpn-devel] [PATCH 6/9] Remove ENABLE_OCC #define

[Gert D. <ge...@gr...>]

Hi,

On Fri, Jul 17, 2020 at 03:47:36PM +0200, Arne Schwabe wrote:
> Commit 037669f3dd already made occ being unconditionally on. This commit
> only removes the #ifdefs
> 
> Signed-off-by: Arne Schwabe <ar...@rf...>

This generally looks good, and does what it says on the tin, so

Acked-By: Gert Doering <ge...@gr...>

I have tried to apply it out of sequence, but that leads to compile-time
errors 

  ld: ssl.o: in function `key_method_1_write':
         .../ssl.c:2239: undefined reference to `local_options_string'

... so the "remove key-method 1" patch must be applied first.

(This is not a show-stopper, just an explanation why I ACK this and
not merge it right away)

gert
-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             ge...@gr...