Re: [Openvpn-devel] [PATCH v4] Make compression asymmetric by default and add warnings

[Lev S. <lst...@gm...>]

Hi,

Apologize for delay.

I tested with various combinations of flags and code works as expected.

Let's reword messages as you proposed:

> We reword the message a bit so that two messages are not that bad if both
> are shown:
>
> WARNING: Compression for receiving enabled, Compression
> has been used in the past to break encryption. Sent packet are not compress unless "allow-compression yes" is also set.

A small typo:

.. Sent packets are not compressed ...

>
>
> WARNING: Compression for sending and receiving enabled, Compression has
> been used in the past to break encryption. Allowing compression allows
> attacks that break encryption. Using '--allow-compression yes' is
> strongly discouraged for common usage. See --compress in the manual
> page for more information

Semi-acked-by: Lev-Stipakov <lst...@gm...>


-- 
-Lev