[Openvpn-devel] [PATCH v2] Change timestamps to ISO 8601 format.

[Gert D. <ge...@gr...>]

All our timestams used to be "what ctime()" produces, which is

  "Thu Aug 11 21:15:27 2016"

Changed to use ISO 8601 standard format, which is

  "2016-08-11 21:15:27"

this applies to logging (except to syslog or if --machine-readable-ouput
is used) and to various other places where informational timestamps are
produced.  Among these are the status files / status to management
interface, so applications parsing these time stamp need to be adjusted.

trac#719

v2: changes.rst, and correctly call this "ISO 8601" not "POSIX"

Signed-off-by: Gert Doering <ge...@gr...>
---
 Changes.rst         | 3 +++
 src/openvpn/otime.c | 7 +++++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/Changes.rst b/Changes.rst
index 9fcba75..ad6363e 100644
--- a/Changes.rst
+++ b/Changes.rst
@@ -135,6 +135,9 @@ User-visible Changes
   ciphers configured in the config file.  Use --ncp-disable if you don't want
   that.
 
+- all time stamps, including log file, status file and management interface,
+  are now output in ISO 8601 standard format.
+
 
 Maintainer-visible changes
 --------------------------
diff --git a/src/openvpn/otime.c b/src/openvpn/otime.c
index 2c1e5b1..c10a6a8 100644
--- a/src/openvpn/otime.c
+++ b/src/openvpn/otime.c
@@ -112,6 +112,7 @@ time_string (time_t t, int usec, bool show_usec, struct gc_arena *gc)
 {
   struct buffer out = alloc_buf_gc (64, gc);
   struct timeval tv;
+  struct tm *tm;
 
   if (t)
     {
@@ -124,8 +125,10 @@ time_string (time_t t, int usec, bool show_usec, struct gc_arena *gc)
     }
 
   t = tv.tv_sec;
-  buf_printf (&out, "%s", ctime(&t));
-  buf_rmtail (&out, '\n');
+  tm = localtime(&t);
+  buf_printf (&out, "%04d-%02d-%02d %02d:%02d:%02d",
+		tm->tm_year+1900, tm->tm_mon+1, tm->tm_mday,
+		tm->tm_hour, tm->tm_min, tm->tm_sec );
 
   if (show_usec && tv.tv_usec)
     buf_printf (&out, " us=%d", (int)tv.tv_usec);
-- 
2.7.3