Re: [Openvpn-devel] [PATCH v7-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

[James Y. <ja...@op...>]

These may have been fixed by now, but noticed some issues in the 
original patch that was discussed in the OpenVPN-devel IRC meeting 
several weeks ago.

* win_adapter_index_to_luid is declared to return a
   NET_LUID but not all code paths return a value.

* wcscat(svchostpath, L"\\svchost.exe") isn't checking
   for buffer overflow.

* FwpmGetAppIdFromFileName0 must be paired with a
   corresponding FwpmFreeMemory0

James