Re: [Openvpn-devel] [PATCH v5-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

[Selva N. <sel...@gm...>]

Hi,

On Sat, Nov 28, 2015 at 10:08 AM, ValdikSS <ia...@va...> wrote:

> Hi!
>
> You have the point, note is confusing on XP. Changed it to "…on Windows
> Vista or later".
>

That doesn't make it any less confusing. If I run a generic 2.3 (i.e no
wfp) build on on windows 7. I'll get that warning even though I am on
"vista or later". So it has to be something like "..not supported in this
build" or whatever... We can't anticipate on what version of windows a
build without wfp compiled-in may be run..


>
> Non-fatal note message is intended to have one config file on various
> platforms without any modifications.
>

There is already a way to handle that. So why break it for someone who
doesn't want to ignore unknown options? In my view a better way is to let
the existing code in options.c handle it appropriately (as fatal or warn
depending on other options, whether its being pushed or read from config
etc..)

Having said that there are other options such as --user and --group which
just generate a warning on windows. It may be its just me being pedantic.
Anyone else?

Selva