Re: [Openvpn-devel] [PATCH] cleanup: windows: convert argv (UCS-2 to UTF-8) at earliest

[David S. <ope...@to...>]

On 24/03/12 21:31, Alon Bar-Lev wrote:
> Discussed at [1].
> 
> Use wmain under windows, drop the custom parsing and shell32 linkage.
> 
> There is no need for gc magic as this allocation is static.
> 
> [1] http://permalink.gmane.org/gmane.network.openvpn.devel/5433
> 
> Signed-off-by: Alon Bar-Lev <alo...@gm...>
> ---
>  src/openvpn/Makefile.am     |    6 +++++-
>  src/openvpn/openvpn.c       |   37 ++++++++++++++++++++++++++++++++++++-
>  src/openvpn/openvpn.vcxproj |   10 ++++++----
>  src/openvpn/options.c       |   27 ---------------------------
>  4 files changed, 47 insertions(+), 33 deletions(-)
>  mode change 100644 => 100755 src/openvpn/openvpn.vcxproj

This patch has been applied to master through lazy consensus.  

The patch has been tested and seems to work perfectly fine, and it have
been discussed in a developers meeting as a reasonable patch to include. 
Thus no reason to delay inclusion any longer.


commit 74370aa89df9285a95084616e9c2d3c8464760b9
Author: Alon Bar-Lev <alo...@gm...>
Date:   Sat Mar 24 22:31:10 2012 +0200

    cleanup: windows: convert argv (UCS-2 to UTF-8) at earliest
      
    Signed-off-by: Alon Bar-Lev <alo...@gm...>
    Message-Id: 133...@gm...
    URL: http://article.gmane.org/gmane.network.openvpn.devel/6063
    Tested-by: Samuli Seppänen <sa...@op...>
    Signed-off-by: David Sommerseth <da...@re...>


kind regards,

David Sommerseth