Re: [Openvpn-devel] [PATCH 3/4] use the underscore version of stat on Windows

[Gert D. <ge...@gr...>]

Hi,

On Thu, Feb 16, 2012 at 06:30:40PM +0100, Heiko Hund wrote:
> MSVC does not know wstat(). Instead _wstat() must be used here.
> Unfortunately _wstat() takes a 'struct _stat'. A type 'stat_t' is
> introduced to handle this situation in a portable way.

Semi-ACK.  

In general, ACK, though it might be a bit easier to understand the code 
if there were an explantory comment at the typedef, and the type would be 
called "openvpn_stat_t" or such - so that when referenced in pf.c, it's 
clear that this is not something "from the build environment" but "local".

gert
-- 
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             ge...@gr...
fax: +49-89-35655025                        ge...@ne...