Re: [Openvpn-devel] [PATCH 2/2] Use %SystemRoot% instead of hard-coded C:\WINDOWS for temp directory path

[Gert D. <ge...@gr...>]

Hi,

On Fri, Apr 08, 2011 at 01:40:05PM +0200, David Sommerseth wrote:
> It is expected that %SystemRoot% is always defined to the directory of the
> Windows system.  If this is undefined, Windows do not work properly.
> 
> So instead of hard-coding C:\WINDOWS\Temp as the default temporary directory
> if %TEMP% or %TMP% is not found, use %SystemRoot%\Temp instead as the fallback.

ACK in principle, but

> +    return NULL; /* Just in case M_FATAL doesn't exit() */

NACK on this.  

We don't do this anywhere else where msg(M_FATAL) is called either - because
we know it won't return.

gert


-- 
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             ge...@gr...
fax: +49-89-35655025                        ge...@ne...