#12 iso1EXIDatatypes.h defines a global variable "characters"

[Moritz Barsnick]

Commit r112, https://sourceforge.net/p/openv2g/code/112/#diff-6, introduced the definition of a global variable "uint8_t characters[20]". (Line 468 of https://svn.code.sf.net/p/openv2g/code/trunk/src/iso1/iso1EXIDatatypes.h@r113).

If you have a project where several C files need to include iso1EXIDatatypes.h, they will create objects with conflicting symbols, and can therefore not be linked together. Removing the defintion works fine.

As far as I can tell, the variable isn't even being used anywhere. It looks like a copy/paste artefact.

[Daniel Peintner]

Thanks for the pointer. Yes, you can safely remove this variable.

This is an artifact of the automatic process that generates all these structures.
I will keep this ticket open until the issue is fixed.

Thanks!

[Mohammed Niyas]

Hello Daniel,

uint8_t characters[20] has been removed in r114 commit (https://sourceforge.net/p/openv2g/code/114/), still why is this ticket not closed?

[Daniel Peintner]

Hi,

Thank you for pointing this out. It was forgotten to close it.

-- Daniel