openutils-svn

[Openutils-svn] SF.net SVN: openutils:[3888] magnoliamodules/trunk/openutils-mgnlcriteria/ src/test/java/net/sourceforge/openutils/mgnlcriteria/advanced/ PaginationTest.java

[<die...@us...>]

Revision: 3888
          http://openutils.svn.sourceforge.net/openutils/?rev=3888&view=rev
Author:   diego_schivo
Date:     2012-03-21 16:20:10 +0000 (Wed, 21 Mar 2012)
Log Message:
-----------
PaginationTest: fix NullPointerException

Modified Paths:
--------------
    magnoliamodules/trunk/openutils-mgnlcriteria/src/test/java/net/sourceforge/openutils/mgnlcriteria/advanced/PaginationTest.java

Modified: magnoliamodules/trunk/openutils-mgnlcriteria/src/test/java/net/sourceforge/openutils/mgnlcriteria/advanced/PaginationTest.java
===================================================================
--- magnoliamodules/trunk/openutils-mgnlcriteria/src/test/java/net/sourceforge/openutils/mgnlcriteria/advanced/PaginationTest.java	2012-03-21 16:19:22 UTC (rev 3887)
+++ magnoliamodules/trunk/openutils-mgnlcriteria/src/test/java/net/sourceforge/openutils/mgnlcriteria/advanced/PaginationTest.java	2012-03-21 16:20:10 UTC (rev 3888)
@@ -19,8 +19,11 @@
 
 package net.sourceforge.openutils.mgnlcriteria.advanced;
 
+import info.magnolia.cms.i18n.DefaultI18nContentSupport;
+import info.magnolia.cms.i18n.I18nContentSupport;
 import info.magnolia.context.MgnlContext;
 import info.magnolia.repository.RepositoryConstants;
+import info.magnolia.test.ComponentsTestUtil;
 import it.openutils.mgnlutils.test.RepositoryTestConfiguration;
 import it.openutils.mgnlutils.test.TestNgRepositoryTestcase;
 import net.sourceforge.openutils.mgnlcriteria.jcr.query.AdvancedResult;
@@ -64,6 +67,8 @@
         // --- Y
         // --- Z
         MgnlContext.getHierarchyManager(RepositoryConstants.WEBSITE).save();
+
+        ComponentsTestUtil.setInstance(I18nContentSupport.class, new DefaultI18nContentSupport());
     }
 
     /**

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Openutils-svn] SF.net SVN: openutils:[4427] magnoliamodules/trunk/openutils-mgnlcriteria/ src/test/java/net/sourceforge/openutils/mgnlcriteria/advanced/ PaginationTest.java

[<fg...@us...>]

Revision: 4427
          http://openutils.svn.sourceforge.net/openutils/?rev=4427&view=rev
Author:   fgiust
Date:     2013-10-21 12:23:22 +0000 (Mon, 21 Oct 2013)
Log Message:
-----------
docs

Modified Paths:
--------------
    magnoliamodules/trunk/openutils-mgnlcriteria/src/test/java/net/sourceforge/openutils/mgnlcriteria/advanced/PaginationTest.java

Modified: magnoliamodules/trunk/openutils-mgnlcriteria/src/test/java/net/sourceforge/openutils/mgnlcriteria/advanced/PaginationTest.java
===================================================================
--- magnoliamodules/trunk/openutils-mgnlcriteria/src/test/java/net/sourceforge/openutils/mgnlcriteria/advanced/PaginationTest.java	2013-10-21 10:25:15 UTC (rev 4426)
+++ magnoliamodules/trunk/openutils-mgnlcriteria/src/test/java/net/sourceforge/openutils/mgnlcriteria/advanced/PaginationTest.java	2013-10-21 12:23:22 UTC (rev 4427)
@@ -177,6 +177,15 @@
         criteria.setMaxResults(10);
         AdvancedResult advResult = criteria.execute();
 
+        // test is broken with jackrabbit > 2.6.1 due to https://issues.apache.org/jira/browse/JCR-3402
+        // starting from jackrabbit 2.6.2 size is only set if the number of fetched nodes is < total number of result,
+        // considering offset (e.g if you have 97 results and paging by 10, the total number will only be returned when
+        // asking for page 10, which is pretty useless)
+        if (advResult.getTotalSize() == -1)
+        {
+            Assert.fail("total number of results not set for query " + criteria.toXpathExpression());
+        }
+
         Assert.assertEquals(advResult.getTotalSize(), 26);
 
         ResultIterator< ? extends Node> resultIterator = advResult.getItems();
@@ -204,6 +213,11 @@
         criteria.setPaging(5, 3);
         AdvancedResult advResult = criteria.execute();
 
+        if (advResult.getTotalSize() == -1)
+        {
+            Assert.fail("total number of results not set for query " + criteria.toXpathExpression());
+        }
+
         Assert.assertEquals(advResult.getTotalSize(), 26);
 
         ResultIterator< ? extends Node> resultIterator = advResult.getItems();
@@ -253,6 +267,12 @@
         criteria.setPaging(5, 1);
 
         AdvancedResult advResult = criteria.execute();
+
+        if (advResult.getTotalSize() == -1)
+        {
+            Assert.fail("total number of results not set for query " + criteria.toXpathExpression());
+        }
+
         Assert.assertEquals(advResult.getTotalSize(), 26);
         Assert.assertEquals(advResult.getNumberOfPages(), 6);
 

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.