[Openutils-svn] SF.net SVN: openutils:[4427] magnoliamodules/trunk/openutils-mgnlcriteria/ src/test/java/net/sourceforge/openutils/mgnlcriteria/advanced/ PaginationTest.java

[<fg...@us...>]

Revision: 4427
          http://openutils.svn.sourceforge.net/openutils/?rev=4427&view=rev
Author:   fgiust
Date:     2013-10-21 12:23:22 +0000 (Mon, 21 Oct 2013)
Log Message:
-----------
docs

Modified Paths:
--------------
    magnoliamodules/trunk/openutils-mgnlcriteria/src/test/java/net/sourceforge/openutils/mgnlcriteria/advanced/PaginationTest.java

Modified: magnoliamodules/trunk/openutils-mgnlcriteria/src/test/java/net/sourceforge/openutils/mgnlcriteria/advanced/PaginationTest.java
===================================================================
--- magnoliamodules/trunk/openutils-mgnlcriteria/src/test/java/net/sourceforge/openutils/mgnlcriteria/advanced/PaginationTest.java	2013-10-21 10:25:15 UTC (rev 4426)
+++ magnoliamodules/trunk/openutils-mgnlcriteria/src/test/java/net/sourceforge/openutils/mgnlcriteria/advanced/PaginationTest.java	2013-10-21 12:23:22 UTC (rev 4427)
@@ -177,6 +177,15 @@
         criteria.setMaxResults(10);
         AdvancedResult advResult = criteria.execute();
 
+        // test is broken with jackrabbit > 2.6.1 due to https://issues.apache.org/jira/browse/JCR-3402
+        // starting from jackrabbit 2.6.2 size is only set if the number of fetched nodes is < total number of result,
+        // considering offset (e.g if you have 97 results and paging by 10, the total number will only be returned when
+        // asking for page 10, which is pretty useless)
+        if (advResult.getTotalSize() == -1)
+        {
+            Assert.fail("total number of results not set for query " + criteria.toXpathExpression());
+        }
+
         Assert.assertEquals(advResult.getTotalSize(), 26);
 
         ResultIterator< ? extends Node> resultIterator = advResult.getItems();
@@ -204,6 +213,11 @@
         criteria.setPaging(5, 3);
         AdvancedResult advResult = criteria.execute();
 
+        if (advResult.getTotalSize() == -1)
+        {
+            Assert.fail("total number of results not set for query " + criteria.toXpathExpression());
+        }
+
         Assert.assertEquals(advResult.getTotalSize(), 26);
 
         ResultIterator< ? extends Node> resultIterator = advResult.getItems();
@@ -253,6 +267,12 @@
         criteria.setPaging(5, 1);
 
         AdvancedResult advResult = criteria.execute();
+
+        if (advResult.getTotalSize() == -1)
+        {
+            Assert.fail("total number of results not set for query " + criteria.toXpathExpression());
+        }
+
         Assert.assertEquals(advResult.getTotalSize(), 26);
         Assert.assertEquals(advResult.getNumberOfPages(), 6);
 

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.