[Openutils-svn] SF.net SVN: openutils:[1481] trunk/openutils-mgnlcriteria/src/main/java/net /sourceforge/openutils/mgnlcriteria/jcr/query/xpath/impl/ MagnoliaCriteriaWithLimitImpl.java

[<fg...@us...>]

Revision: 1481
          http://openutils.svn.sourceforge.net/openutils/?rev=1481&view=rev
Author:   fgrilli
Date:     2009-10-09 19:31:24 +0000 (Fri, 09 Oct 2009)

Log Message:
-----------
removed vacuous comparison of integer value (thus spoke Findbugs)

Modified Paths:
--------------
    trunk/openutils-mgnlcriteria/src/main/java/net/sourceforge/openutils/mgnlcriteria/jcr/query/xpath/impl/MagnoliaCriteriaWithLimitImpl.java

Modified: trunk/openutils-mgnlcriteria/src/main/java/net/sourceforge/openutils/mgnlcriteria/jcr/query/xpath/impl/MagnoliaCriteriaWithLimitImpl.java
===================================================================
--- trunk/openutils-mgnlcriteria/src/main/java/net/sourceforge/openutils/mgnlcriteria/jcr/query/xpath/impl/MagnoliaCriteriaWithLimitImpl.java	2009-10-09 19:08:04 UTC (rev 1480)
+++ trunk/openutils-mgnlcriteria/src/main/java/net/sourceforge/openutils/mgnlcriteria/jcr/query/xpath/impl/MagnoliaCriteriaWithLimitImpl.java	2009-10-09 19:31:24 UTC (rev 1481)
@@ -103,17 +103,17 @@
             org.apache.jackrabbit.core.query.QueryImpl q = (org.apache.jackrabbit.core.query.QueryImpl) jcrManager
                 .createQuery(stmt, Query.XPATH);
 
-            if (getMaxResults() <= 0 || getMaxResults() > Integer.MAX_VALUE)
+            if (getMaxResults() <= 0)
             {
-                String msg = "maxResults value [" + getMaxResults() + "] is out of the accepted range";
+                String msg = "maxResults value [" + getMaxResults() + "] cannot be less than or equal to 0";
                 log.error(msg);
                 throw new InvalidQueryException(msg);
             }
             q.setLimit(getMaxResults());
 
-            if (getFirstResult() < 0 || getFirstResult() > Integer.MAX_VALUE)
+            if (getFirstResult() < 0)
             {
-                String msg = "firstResult value [" + getFirstResult() + "] is out of the accepted range";
+                String msg = "firstResult value [" + getFirstResult() + "] cannot be less than 0";
                 log.error(msg);
                 throw new InvalidQueryException(msg);
             }
@@ -213,7 +213,7 @@
         private javax.jcr.query.QueryResult result;
 
         private AccessManager accessManager;
-        
+
         private HierarchyManager hm;
 
         private Map<String, String> dirtyHandles = new Hashtable<String, String>();


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.