[Openutils-svn] SF.net SVN: openutils: [666] trunk/openutils-hibernate-security/src/main/ java/it/openutils/hibernate/security/filter/SecurityRuleUtils.java

[<fc...@us...>]

Revision: 666
          http://openutils.svn.sourceforge.net/openutils/?rev=666&view=rev
Author:   fcarone
Date:     2008-02-20 07:36:56 -0800 (Wed, 20 Feb 2008)

Log Message:
-----------
Switch case is nicer for enums

Modified Paths:
--------------
    trunk/openutils-hibernate-security/src/main/java/it/openutils/hibernate/security/filter/SecurityRuleUtils.java

Modified: trunk/openutils-hibernate-security/src/main/java/it/openutils/hibernate/security/filter/SecurityRuleUtils.java
===================================================================
--- trunk/openutils-hibernate-security/src/main/java/it/openutils/hibernate/security/filter/SecurityRuleUtils.java	2008-02-20 15:36:09 UTC (rev 665)
+++ trunk/openutils-hibernate-security/src/main/java/it/openutils/hibernate/security/filter/SecurityRuleUtils.java	2008-02-20 15:36:56 UTC (rev 666)
@@ -3,7 +3,6 @@
  */
 package it.openutils.hibernate.security.filter;
 
-import it.openutils.hibernate.security.dataobject.ModifierEnum;
 import it.openutils.hibernate.security.dataobject.PermissionEnum;
 import it.openutils.hibernate.security.dataobject.SecurityRule;
 
@@ -75,26 +74,24 @@
             for (SecurityRule rule : rules)
             {
                 String objProperty = BeanUtils.getSimpleProperty(argument, rule.getProperty());
-                if (rule.getModifier().equals(ModifierEnum.EQUALS))
+                switch (rule.getModifier())
                 {
-                    if (StringUtils.equals(objProperty, rule.getValue()))
-                    {
-                        log.debug("Matching rule found: {}", rule);
-                        return true;
-                    }
+                    case EQUALS:
+                        if (StringUtils.equals(objProperty, rule.getValue()))
+                        {
+                            log.debug("Matching rule found: {}", rule);
+                            return true;
+                        }
+
+                    case NOT:
+                        if (!StringUtils.equals(objProperty, rule.getValue()))
+                        {
+                            log.debug("Matching rule found: {}", rule);
+                            return true;
+                        }
+                    default:
+                        throw new RuntimeException("Modifier " + rule.getModifier() + " is not recognized");
                 }
-                else if (rule.getModifier().equals(ModifierEnum.NOT))
-                {
-                    if (!StringUtils.equals(objProperty, rule.getValue()))
-                    {
-                        log.debug("Matching rule found: {}", rule);
-                        return true;
-                    }
-                }
-                else
-                {
-                    throw new RuntimeException("Modifier " + rule.getModifier() + " is not recognized");
-                }
             }
         }
         catch (NoSuchMethodException e)


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.