Thread: [openupload-devel] Problems with grouponip plugin
Status: Beta
Brought to you by:
tsdogs
Menu
▾
▴
openupload-devel
|
From: <wal...@no...> - 2011-04-08 10:30:29
|
Hi, first I'dl like to thank Allesandro for his good work. I have some problems with the grouponip plugin. (openupload 0.4.2) I activated it such people coming with our corporate Ip addresses can upload without authenticating . Problem 1 Strangely enough, if I enter the website url in the browser adress bar I get redirected to the authentication form. If I remove the 'index.php?action=login' in the adress bar and then hit enter, then I can see the upload form. Problem 2 One a user gets the link to delete file, if he clicks once on the links he get redirected to the autentication form. If he clicks a second time, then he can see the deletion form. This is very disturbing for our end users. I guess the two problems are related. Any idea of how to solve it ? Regards W |
|
From: <wal...@no...> - 2011-04-08 11:21:13
|
I seem to have found a fix, but I'm not sure there is no side effect : if
anyone could tell me if what I'm doing is safe :
in openuload/lib/main.inc.php , I move $this->initPlugins(); upper in the
file source so now it reads :
$this->initPlugins();
/* get the handling module */
$mname = $this->actions[$this->action];
$m = &$this->modules[$mname];
$group = $this->user->group();
As the init function of grouponip module is setting the user group, the
call to $group = $this->user->group() gets a valid value and my problems
are solved.
Any thoughts on this ?
Regards,
W.
> Hi,
> first I'dl like to thank Allesandro for his good work.
>
> I have some problems with the grouponip plugin. (openupload 0.4.2)
>
> I activated it such people coming with our corporate Ip addresses can
> upload without authenticating .
>
> Problem 1
> Strangely enough, if I enter the website url in the browser adress bar I
> get redirected to the authentication form. If I remove the
> 'index.php?action=login' in the adress bar and then hit enter, then I can
> see the upload form.
>
> Problem 2
> One a user gets the link to delete file, if he clicks once on the links he
> get redirected to the autentication form. If he clicks a second time, then
> he can see the deletion form. This is very disturbing for our end users.
>
> I guess the two problems are related.
>
> Any idea of how to solve it ?
>
> Regards
> W
>
>
>
|
|
From: Alessandro B. <ts...@br...> - 2011-04-09 11:48:39
|
On Fri, 8 Apr 2011 13:21:05 +0200 (CEST), wal...@no... wrote: > I seem to have found a fix, but I'm not sure there is no side effect > : if > anyone could tell me if what I'm doing is safe : > > in openuload/lib/main.inc.php , I move $this->initPlugins(); upper > in the > file source so now it reads : > > $this->initPlugins(); > /* get the handling module */ > $mname = $this->actions[$this->action]; > $m = &$this->modules[$mname]; > $group = $this->user->group(); > > > As the init function of grouponip module is setting the user group, > the > call to $group = $this->user->group() gets a valid value and my > problems > are solved. > > Any thoughts on this ? > > Regards, > Yeah, that's probably it. AFAIR this should not give any side effect unless the plugins init function does not rely on the action and group. Alessandro |
|
From: Alessandro B. <ts...@br...> - 2011-04-09 11:47:03
|
On Fri, 8 Apr 2011 12:30:21 +0200 (CEST), wal...@no... wrote: > Hi, > first I'dl like to thank Allesandro for his good work. > > I have some problems with the grouponip plugin. (openupload 0.4.2) > > I activated it such people coming with our corporate Ip addresses can > upload without authenticating . > > Problem 1 > Strangely enough, if I enter the website url in the browser adress > bar I > get redirected to the authentication form. If I remove the > 'index.php?action=login' in the adress bar and then hit enter, then I > can > see the upload form. > > Problem 2 > One a user gets the link to delete file, if he clicks once on the > links he > get redirected to the autentication form. If he clicks a second time, > then > he can see the deletion form. This is very disturbing for our end > users. > > I guess the two problems are related. > > Any idea of how to solve it ? Hi, haven't checked it but probably it is setting the "user/group" too late, so the auth module is denying access to the functionality the first time. Alessandro |
|
From: wallander <wal...@no...> - 2011-04-09 12:00:39
Attachments:
openupload.po
template.po
|
Hi, I'm not sure this is the better way to send the french .po files, but anyway here are new and slightly improved versions ( hoping attachments are not removed). The original translation was quite good. I corrected mainly (but not only) mispelled words. There still is a small problem : both 'plugin' and 'module' are translated to 'module' . W. |
|
From: Alessandro B. <ts...@br...> - 2011-04-09 12:06:53
|
On Sat, 09 Apr 2011 14:00:06 +0200, wallander wrote: > Hi, > I'm not sure this is the better way to send the french .po files, but > anyway here are new and slightly improved versions ( hoping > attachments > are not removed). > > The original translation was quite good. I corrected mainly (but not > only) mispelled words. > > There still is a small problem : both 'plugin' and 'module' are > translated to 'module' . > Thanks. Is this a bug in the way translations are handled in open upload or is it that french does not have a word for Plugin? Alessandro |
|
From: wallander <wal...@no...> - 2011-04-09 12:12:26
|
No bug. It is the choice the original translator did. I can think of two ways of translating 'plugin' in french : 1) plugin -> plugin 2) plugin -> greffon ( as it is done in the Gimp ) I could provide new translations files ( I understand the best way is to provide .po files) , but not right now. W Le 09/04/11 14:06, Alessandro Briosi a écrit : > On Sat, 09 Apr 2011 14:00:06 +0200, wallander wrote: >> Hi, >> I'm not sure this is the better way to send the french .po files, but >> anyway here are new and slightly improved versions ( hoping >> attachments >> are not removed). >> >> The original translation was quite good. I corrected mainly (but not >> only) mispelled words. >> >> There still is a small problem : both 'plugin' and 'module' are >> translated to 'module' . >> > Thanks. > > Is this a bug in the way translations are handled in open upload > or is it that french does not have a word for Plugin? > > Alessandro > > ------------------------------------------------------------------------------ > Xperia(TM) PLAY > It's a major breakthrough. An authentic gaming > smartphone on the nation's most reliable network. > And it wants your games. > http://p.sf.net/sfu/verizon-sfdev > _______________________________________________ > Openupload-devel mailing list > Ope...@li... > https://lists.sourceforge.net/lists/listinfo/openupload-devel |
|
From: gmail <lau...@gm...> - 2011-04-09 15:25:53
|
Le 09/04/2011 14:06, Alessandro Briosi a écrit : > On Sat, 09 Apr 2011 14:00:06 +0200, wallander wrote: >> Hi, >> I'm not sure this is the better way to send the french .po files, but >> anyway here are new and slightly improved versions ( hoping >> attachments >> are not removed). >> >> The original translation was quite good. I corrected mainly (but not >> only) mispelled words. >> >> There still is a small problem : both 'plugin' and 'module' are >> translated to 'module' . >> "greffon" is the french translation for plugin. > Thanks. > > Is this a bug in the way translations are handled in open upload > or is it that french does not have a word for Plugin? > > Alessandro > > ------------------------------------------------------------------------------ > Xperia(TM) PLAY > It's a major breakthrough. An authentic gaming > smartphone on the nation's most reliable network. > And it wants your games. > http://p.sf.net/sfu/verizon-sfdev > _______________________________________________ > Openupload-devel mailing list > Ope...@li... > https://lists.sourceforge.net/lists/listinfo/openupload-devel |
Thanks for helping keep SourceForge clean.
X