Re: [openupload-devel] Problem with Banned
Status: Beta
Brought to you by:
tsdogs
|
From: Alessandro B. <ts...@br...> - 2011-09-14 12:30:06
|
On Tue, 13 Sep 2011 13:55:54 +0100, Steve Allum wrote: > Hi > > Just playing with openupload as it looks like a real answer to a > problem we have had for a while. > > I have it up and running on a trial server and while I need to look > at the some of the options like captcha because I don't gave GD > installed, I am very impressed with the ease of use and > fuunctionality > > My problem is with the banned addresses plugin. > >>From my testing the deny/allow list held in banned.txt seems to work >> on the order the entries exist rather than the priority given > > For example the standard file shows > > id|ip|access|priority > 1|127.0.0.1|allow|1 > 2|0.0.0.0/0|allow|999 > > Adding another entry using the Gui changes it to > > id|ip|access|priority > 1|127.0.0.1|allow|1 > 2|0.0.0.0/0|allow|999 > 3|10.60.10.244|deny|5 > > The final entry is my own internal IP and I am not blocked. It > appears that the entry at 2 overrides the antry at 3 despite the > priorities. > > I tested by manually editing the banned.txt file to put the rules in > what looks like the correct order > > id|ip|access|priority > 1|127.0.0.1|allow|1 > 2|10.60.10.244|deny|5 > 3|0.0.0.0/0|allow|999 > > In this format everything works as expected and my address is banned > but everything else is allowed. > > Is this a known bug? Have I got a config error? > > Thanks > Hi Steve, this is a specific problem/bug with the txt database backend which does not sort based on the priority. Changing database backend, whould fix it. Alessandro |