Re: [openupload-devel] New Plugin: account_expire

[Alessandro B. <ts...@br...>]

Hi Jochen,
I'm not really convinced about this.
Though coding is correct (only minor fixes), the plugin must be enabled 
also for admins to be used in the administration page.

Imho, we should differenciate between plugins for functionality, and 
administration.

Won't commit it right now. I'll have a look in the next few days on how 
to fix this.
I already thought that a module and a plugin should handle the 
administration of itself, and not the admin module. That's another thing 
I want to change for 0.5

Ciao,
Alessandro

P.S. I suppose you are coding on Windows as I had some troubles finding 
out that the directory for the templates was called accountExpire and 
not accountexpire. Please use all lowercase for the file/directories.

Jochen Derwae ha scritto:
> Dear Alessandro,
> 
> I've finally come round to finishing the first version of the account_expire
> plugin. The administrator can now enter an expiration date in the user form.
> This date is checkec when the user tries to log on, to allow or deny
> authentication.
> 
> I did have to make some minor changes to the admin module (to call and
> display plugins in the useredit method) in order to get this plugin to work.
> The code I've provided is probably not up to the standards of the rest of
> the code base. I think mostly acl is missing from this plugin. I would still
> appreciate it if you could take a look and tell me what you think.
> 
> I'm going to work on assigning files to groups now, I might do it
> differently then what you had in mind, due to the database code not being
> able to do joins. Anyway, I'll patch something together (-:
> 
> Thanks,
> Jochen
> 
> 
> ------------------------------------------------------------------------
> 
> ------------------------------------------------------------------------------
> Crystal Reports - New Free Runtime and 30 Day Trial
> Check out the new simplified licensing option that enables 
> unlimited royalty-free distribution of the report engine 
> for externally facing server and web deployment. 
> http://p.sf.net/sfu/businessobjects
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Openupload-devel mailing list
> Ope...@li...
> https://lists.sourceforge.net/lists/listinfo/openupload-devel