Re: [openupload-devel] (no subject)

[Alessandro B. <ts...@br...>]

Hello Hajek,
Thanks for the report, though I'm not really sure that this patch is 
correct, as it sets all contents to be binary and application/octet-stream

I'll do a few tests with IE7 and SSL enabled to verity.

Alessandro

P.S. I had to approve your message as it was posted by a non ML member.

Hajek Ladislav (IT) ha scritto:
> Good day,
>  
> We are usage openupload and discovered you are bug in application.When 
> you downloading some mime types with MSIE7, for example 
> application/gzip, browser can´t download in https ssl mode. Correction 
> is see openupload_att.txt
> (edit file files.inc.php).
>  
> 
> best regards
>  
> 
> **Ladislav Hájek**
> 
> HQ Systémový administrátor / HQ Systems administrator
> 
> PENTA INVESTMENTS LIMITED,o.s.
> Na Příkopě 15
> 110 00  Praha 1
> Česká republika
> 
> T    +420 225 101 127
> M    +420 733 698 861
> E      ha...@pe...
> W     www.pentainvestments.com
> 
> Please Consider The Environment Before Printing This E-mail.
> 
>  
>  
>  
> --- files.inc.php.old 2009-01-13 00:44:56.000000000 +0100
> +++ files.inc.php 2009-01-13 00:49:23.000000000 +0100
> @@ -372,10 +372,18 @@
>        app()->log('notice','serveFile','','ALLOW',$finfo[$num]['id']);
>       /* disable and clean output buffer so it won't reach memory limit */
>        ob_end_clean();
> -      header('Content-Type: '.$finfo[$num]['mime']);
> -      header('Content-Length: '.$filesize);
> -      header('Content-Disposition: attachment; 
> filename="'.$finfo[$num]['name'].'"');
> -      readfile($file);
> +
> + header('Content-Description: File Transfer');
> +     header('Content-Type: application/octet-stream');
> + header('Content-Disposition: attachment; 
> filename="'.$finfo[$num]['name'].'"');
> + header('Content-Transfer-Encoding: binary');
> +    header('Expires: 0');
> + header('Cache-Control: must-revalidate, post-check=0, pre-check=0');
> + header('Pragma: public');
> + header('Content-Length: ' .$filesize);
> + ob_clean();
> + flush;
> +  readfile($file);
>        /* file should have been sent now let's reset the download info */
>        if (!$_SESSION['user']['d'][0]['protected'])
>          $_SESSION['user']['d'][$num]['candownload']='ok';
> 
> 
> ------------------------------------------------------------------------
> 
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by:
> SourcForge Community
> SourceForge wants to tell your story.
> http://p.sf.net/sfu/sf-spreadtheword
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Openupload-devel mailing list
> Ope...@li...
> https://lists.sourceforge.net/lists/listinfo/openupload-devel