Re: [Opentnl-general] Cygwin & mingw32 fixes
Brought to you by:
mark_frohnmayer,
s_alanet
From: Ben G. <be...@ga...> - 2004-04-23 01:49:55
|
Stephane, It looks like a good fix. Nice work! We'll have to run it past Quigley, our linux build master, so that he can approve it (since MingW/Cygwin both use the same toolchain as linux), so it may take a few days to get feedback. He's currently at the Linux Desktop Summit, and thus incommunicado. :) You will also need to fill out and send to us the form located at <http://www.opentnl.org/agreement.html>. It's a joint copyright assignment; an unfortunate necessity for projects operating under dual licenses. :) If you have any questions feel free to ask (though you might want to do it off-list). Regards, Ben Garney Stephane Vaxelaire wrote: >Hi, > > > >>Strangely GCC doesn't give this error on either linux or OS X. Perhaps >>it's a difference in the cdecl syntax? >> >> > >You got the point. In fact for both __CYGWIN__ and __MINGW32__ the FN_CDECL >constant must be defined to nothing like under Linux for instance. > >There are also some missing constants under mingw32 so I added them directly >in tnlTypes.h in a test to check if __MINGW32__ is defined. >Now I got everything to compile fine with standard gcc cygwin and with >gcc -mno-cygwin. >For pure cygwin, TNL_OS is defined to linux whereas for mingw it is defined to >win32. > >Of course, for mingw compile, I had to add "-mno-cygwin" to each Makefile (or >makefile in libtomcrypt) and I had to add -lwsock32 to the Makefiles in the >master, masterclient and test subdirectories. >No changes to Makefiles where required for cygwin, just the new tnlTypes.h. > >Here you will find (attached) my tnlType.h file that I modified from yesterday's >CVS. > >Could any devel commit this patch if it proves itself to be ok ? >I dunno how to integrate the mingw32 required changes to Makefiles though.. >I should say I haven't thought about it. Is anyone planning to use a configure >script ? > >Regards, > >Stephane > |