opentac2-developers

[Opentac2-developers] Agenda for OpenTAC2 developement

[Seth M. <mr...@ph...>]

Hi everyone!

Please be sure that you've installed Maven (http://maven.apache.org) and
check out the current code branch (opentac2-1-0). I have reorganized
everything from the main trunk as per request by Veljar. This includes:

	1) Getting rid of mass amounts of unused cruft (tld's, jars, etc.)

	2) Moving all JSP's under the WEB-INF directory (to WEB-INF/jsp);

	3) Enforcing the notion that every page corresponds to an action.	I.e.,
no referencing directly to a jsp.

The first thing I'd like to discuss is basic design. The best way to
understand the system is to look at the file schema/project-schema.xml.
I am sorry there are no UML diagrams. If someone has a simple way of
doing this, that'd be great!

The code is still recovering from major surgery, but I think it is 
finally in a state where I think we can let the hacking begin! Sorry it 
took so long, but I was first in CVS hell, followed by jar hell and I 
did not want to subject anyone else to this. Anyhow, I still have the 
old code up on opentac.gmu.edu, so we can at least use that as a loose 
reference for the functional specs. The new code is still largely broken 
due to significant changes in the way user security is handled and also 
because of changes to the core schema (schema/project-schema.xml).

What does you guys think about everyone choosing certain components of 
the code that you'll then "own?" We could almost go through 
struts-config.xml and just pick actions or groups of actions to work on.

I think we should have a conference over IM so we can all discuss this 
in real time.

-- 
Seth Milder
Department of Physics and Astronomy
MS 3f3
George Mason University
Fairfax, VA
--
Politics is the art of looking for trouble, finding it whether it exists
or not, diagnosing it incorrectly, and applying the wrong remedy. ERNEST
BENN

Re: [Opentac2-developers] Agenda for OpenTAC2 developement

[Arun J. E. <jac...@gm...>]

Hello, Seth,

Nice to see your email.

Could you give me the CVS details, like repository path. I beleive host is :
opentac.gmu.edu

Which chat client you use. I use MSN and IRC.

Regards,

Arun

On Wed, 13 Oct 2004 20:16:11 -0400, Seth Milder <mr...@ph...> wrote:
> Hi everyone!
> 
> Please be sure that you've installed Maven (http://maven.apache.org) and
> check out the current code branch (opentac2-1-0). I have reorganized
> everything from the main trunk as per request by Veljar. This includes:
> 
>        1) Getting rid of mass amounts of unused cruft (tld's, jars, etc.)
> 
>        2) Moving all JSP's under the WEB-INF directory (to WEB-INF/jsp);
> 
>        3) Enforcing the notion that every page corresponds to an action.       I.e.,
> no referencing directly to a jsp.
> 
> The first thing I'd like to discuss is basic design. The best way to
> understand the system is to look at the file schema/project-schema.xml.
> I am sorry there are no UML diagrams. If someone has a simple way of
> doing this, that'd be great!
> 
> The code is still recovering from major surgery, but I think it is
> finally in a state where I think we can let the hacking begin! Sorry it
> took so long, but I was first in CVS hell, followed by jar hell and I
> did not want to subject anyone else to this. Anyhow, I still have the
> old code up on opentac.gmu.edu, so we can at least use that as a loose
> reference for the functional specs. The new code is still largely broken
> due to significant changes in the way user security is handled and also
> because of changes to the core schema (schema/project-schema.xml).
> 
> What does you guys think about everyone choosing certain components of
> the code that you'll then "own?" We could almost go through
> struts-config.xml and just pick actions or groups of actions to work on.
> 
> I think we should have a conference over IM so we can all discuss this
> in real time.
> 
> --
> Seth Milder
> Department of Physics and Astronomy
> MS 3f3
> George Mason University
> Fairfax, VA
> --
> Politics is the art of looking for trouble, finding it whether it exists
> or not, diagnosing it incorrectly, and applying the wrong remedy. ERNEST
> BENN
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
> Use IT products in your business? Tell us what you think of them. Give us
> Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
> http://productguide.itmanagersjournal.com/guidepromo.tmpl
> _______________________________________________
> Opentac2-developers mailing list
> Ope...@li...
> https://lists.sourceforge.net/lists/listinfo/opentac2-developers
>

Re: [Opentac2-developers] Agenda for OpenTAC2 developement

[Seth M. <mr...@ph...>]

Arun Jacob Elias wrote:
> Hello, Seth,
> 
> Nice to see your email.
> 
> Could you give me the CVS details, like repository path. I beleive host is :
> opentac.gmu.edu
> 
> Which chat client you use. I use MSN and IRC.
> 
> Regards,
> 
> Arun
> 


I do not really do Windows, so MSN is out for me. I've never done IRC, 
but that may be a good way to go. I am on Yahoo as pl0pper and AIM as 
sdmilder. Also I will need to add some of you to the developer list for 
opentac2 at sourceforge. To check out the code you do this:

cvs -d :ext:myS...@cv...:/cvsroot/opentac2 
co -r opentac2-1-0 opentac2

Of course, all that should be on one line.

-- 
Seth Milder
Department of Physics and Astronomy
MS 3f3
George Mason University
Fairfax, VA
--
"The question is complex and life is short." --Protagoras on the 
existence of the gods

Re: [Opentac2-developers] Agenda for OpenTAC2 developement

[Arun J. E. <jac...@gm...>]

I use eclipse as IDE.

which one do you use.

Arun


On Thu, 14 Oct 2004 00:27:59 -0400, Seth Milder <mr...@ph...> wrote:
> Arun Jacob Elias wrote:
> > Hello, Seth,
> >
> > Nice to see your email.
> >
> > Could you give me the CVS details, like repository path. I beleive host is :
> > opentac.gmu.edu
> >
> > Which chat client you use. I use MSN and IRC.
> >
> > Regards,
> >
> > Arun
> >
> 
> 
> I do not really do Windows, so MSN is out for me. I've never done IRC,
> but that may be a good way to go. I am on Yahoo as pl0pper and AIM as
> sdmilder. Also I will need to add some of you to the developer list for
> opentac2 at sourceforge. To check out the code you do this:
> 
> cvs -d :ext:myS...@cv...:/cvsroot/opentac2
> co -r opentac2-1-0 opentac2
> 
> Of course, all that should be on one line.
> 
> --
> Seth Milder
> Department of Physics and Astronomy
> MS 3f3
> George Mason University
> Fairfax, VA
> --
> "The question is complex and life is short." --Protagoras on the
> existence of the gods
> 
> 
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
> Use IT products in your business? Tell us what you think of them. Give us
> Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
> http://productguide.itmanagersjournal.com/guidepromo.tmpl
> _______________________________________________
> Opentac2-developers mailing list
> Ope...@li...
> https://lists.sourceforge.net/lists/listinfo/opentac2-developers
>

Re: [Opentac2-developers] Agenda for OpenTAC2 developement

[Vlada D. <vla...@ya...>]

--- Seth Milder <mr...@ph...> wrote:

> Hi everyone!
> 
> Please be sure that you've installed Maven
> (http://maven.apache.org) and
> check out the current code branch (opentac2-1-0). I
> have reorganized
> everything from the main trunk as per request by
> Veljar. This includes:
> 
> 	1) Getting rid of mass amounts of unused cruft
> (tld's, jars, etc.)
> 
> 	2) Moving all JSP's under the WEB-INF directory (to
> WEB-INF/jsp);
> 
> 	3) Enforcing the notion that every page corresponds
> to an action.	I.e.,
> no referencing directly to a jsp.
> 

This part is maybe slightly off-topic. I managed to
checkout and build new branch, and I noticed that
there are fewer JSP's in WEB-INF/jsp then there were
in initial checkout. Is this OK?

> The first thing I'd like to discuss is basic design.
> The best way to
> understand the system is to look at the file
> schema/project-schema.xml.
> I am sorry there are no UML diagrams. If someone has
> a simple way of
> doing this, that'd be great!
> 
> The code is still recovering from major surgery, but
> I think it is 
> finally in a state where I think we can let the
> hacking begin! Sorry it 
> took so long, but I was first in CVS hell, followed
> by jar hell and I 
> did not want to subject anyone else to this. Anyhow,
> I still have the 
> old code up on opentac.gmu.edu, so we can at least
> use that as a loose 
> reference for the functional specs. The new code is
> still largely broken 
> due to significant changes in the way user security
> is handled and also 
> because of changes to the core schema
> (schema/project-schema.xml).
> 
> What does you guys think about everyone choosing
> certain components of 
> the code that you'll then "own?" We could almost go
> through 
> struts-config.xml and just pick actions or groups of
> actions to work on.
> 
> I think we should have a conference over IM so we
> can all discuss this 
> in real time.
> 
Maybe it's better to use IRC (just saying this because
I don't use IM :-) ). And schedule it in some
timezone-independent time.

> -- 
> Seth Milder
> Department of Physics and Astronomy
> MS 3f3
> George Mason University
> Fairfax, VA
> --
>

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

Re: [Opentac2-developers] Agenda for OpenTAC2 developement

[Arun J. E. <jac...@gm...>]

IRC would be better


On Wed, 13 Oct 2004 23:43:13 -0700 (PDT), Vlada Djurovic
<vla...@ya...> wrote:
> 
> --- Seth Milder <mr...@ph...> wrote:
> 
> > Hi everyone!
> >
> > Please be sure that you've installed Maven
> > (http://maven.apache.org) and
> > check out the current code branch (opentac2-1-0). I
> > have reorganized
> > everything from the main trunk as per request by
> > Veljar. This includes:
> >
> >       1) Getting rid of mass amounts of unused cruft
> > (tld's, jars, etc.)
> >
> >       2) Moving all JSP's under the WEB-INF directory (to
> > WEB-INF/jsp);
> >
> >       3) Enforcing the notion that every page corresponds
> > to an action. I.e.,
> > no referencing directly to a jsp.
> >
> 
> This part is maybe slightly off-topic. I managed to
> checkout and build new branch, and I noticed that
> there are fewer JSP's in WEB-INF/jsp then there were
> in initial checkout. Is this OK?
> 
> > The first thing I'd like to discuss is basic design.
> > The best way to
> > understand the system is to look at the file
> > schema/project-schema.xml.
> > I am sorry there are no UML diagrams. If someone has
> > a simple way of
> > doing this, that'd be great!
> >
> > The code is still recovering from major surgery, but
> > I think it is
> > finally in a state where I think we can let the
> > hacking begin! Sorry it
> > took so long, but I was first in CVS hell, followed
> > by jar hell and I
> > did not want to subject anyone else to this. Anyhow,
> > I still have the
> > old code up on opentac.gmu.edu, so we can at least
> > use that as a loose
> > reference for the functional specs. The new code is
> > still largely broken
> > due to significant changes in the way user security
> > is handled and also
> > because of changes to the core schema
> > (schema/project-schema.xml).
> >
> > What does you guys think about everyone choosing
> > certain components of
> > the code that you'll then "own?" We could almost go
> > through
> > struts-config.xml and just pick actions or groups of
> > actions to work on.
> >
> > I think we should have a conference over IM so we
> > can all discuss this
> > in real time.
> > 
> Maybe it's better to use IRC (just saying this because
> I don't use IM :-) ). And schedule it in some
> timezone-independent time.
> 
> > --
> > Seth Milder
> > Department of Physics and Astronomy
> > MS 3f3
> > George Mason University
> > Fairfax, VA
> > --
> >
> 
> __________________________________________________
> Do You Yahoo!?
> Tired of spam?  Yahoo! Mail has the best spam protection around
> http://mail.yahoo.com 
> 
> 
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
> Use IT products in your business? Tell us what you think of them. Give us
> Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
> http://productguide.itmanagersjournal.com/guidepromo.tmpl
> _______________________________________________
> Opentac2-developers mailing list
> Ope...@li...
> https://lists.sourceforge.net/lists/listinfo/opentac2-developers
>

Re: [Opentac2-developers] Agenda for OpenTAC2 developement

[Seth M. <mr...@ph...>]

Vlada Djurovic wrote:
> --- Seth Milder <mr...@ph...> wrote:
> 
> 
>>Hi everyone!
>>
>>Please be sure that you've installed Maven
>>(http://maven.apache.org) and
>>check out the current code branch (opentac2-1-0). I
>>have reorganized
>>everything from the main trunk as per request by
>>Veljar. This includes:
>>
>>	1) Getting rid of mass amounts of unused cruft
>>(tld's, jars, etc.)
>>
>>	2) Moving all JSP's under the WEB-INF directory (to
>>WEB-INF/jsp);
>>
>>	3) Enforcing the notion that every page corresponds
>>to an action.	I.e.,
>>no referencing directly to a jsp.
>>
> 
> 
> This part is maybe slightly off-topic. I managed to
> checkout and build new branch, and I noticed that
> there are fewer JSP's in WEB-INF/jsp then there were
> in initial checkout. Is this OK?
> 

You are right. I still have some JSP's to migrate. I will do that today.


> 
>>The first thing I'd like to discuss is basic design.
>>The best way to
>>understand the system is to look at the file
>>schema/project-schema.xml.
>>I am sorry there are no UML diagrams. If someone has
>>a simple way of
>>doing this, that'd be great!
>>
>>The code is still recovering from major surgery, but
>>I think it is 
>>finally in a state where I think we can let the
>>hacking begin! Sorry it 
>>took so long, but I was first in CVS hell, followed
>>by jar hell and I 
>>did not want to subject anyone else to this. Anyhow,
>>I still have the 
>>old code up on opentac.gmu.edu, so we can at least
>>use that as a loose 
>>reference for the functional specs. The new code is
>>still largely broken 
>>due to significant changes in the way user security
>>is handled and also 
>>because of changes to the core schema
>>(schema/project-schema.xml).
>>
>>What does you guys think about everyone choosing
>>certain components of 
>>the code that you'll then "own?" We could almost go
>>through 
>>struts-config.xml and just pick actions or groups of
>>actions to work on.
>>
>>I think we should have a conference over IM so we
>>can all discuss this 
>>in real time.
>>
> 
> Maybe it's better to use IRC (just saying this because
> I don't use IM :-) ). And schedule it in some
> timezone-independent time.
> 

I am fine with that. Can you or Arun arrange this?

-- 
Seth Milder
Department of Physics and Astronomy
MS 3f3
George Mason University
Fairfax, VA
--
Heisenberg may have been here.

Re: [Opentac2-developers] Agenda for OpenTAC2 developement

[Arun J. E. <jac...@gm...>]

Time should be convinient to all.

Let other members suggest a time and we will agree upon IRC

Regards,

Arun


On Thu, 14 Oct 2004 11:28:41 -0400, Seth Milder <mr...@ph...> wrote:
> Vlada Djurovic wrote:
> > --- Seth Milder <mr...@ph...> wrote:
> >
> >
> >>Hi everyone!
> >>
> >>Please be sure that you've installed Maven
> >>(http://maven.apache.org) and
> >>check out the current code branch (opentac2-1-0). I
> >>have reorganized
> >>everything from the main trunk as per request by
> >>Veljar. This includes:
> >>
> >>      1) Getting rid of mass amounts of unused cruft
> >>(tld's, jars, etc.)
> >>
> >>      2) Moving all JSP's under the WEB-INF directory (to
> >>WEB-INF/jsp);
> >>
> >>      3) Enforcing the notion that every page corresponds
> >>to an action. I.e.,
> >>no referencing directly to a jsp.
> >>
> >
> >
> > This part is maybe slightly off-topic. I managed to
> > checkout and build new branch, and I noticed that
> > there are fewer JSP's in WEB-INF/jsp then there were
> > in initial checkout. Is this OK?
> >
> 
> You are right. I still have some JSP's to migrate. I will do that today.
> 
> 
> >
> >>The first thing I'd like to discuss is basic design.
> >>The best way to
> >>understand the system is to look at the file
> >>schema/project-schema.xml.
> >>I am sorry there are no UML diagrams. If someone has
> >>a simple way of
> >>doing this, that'd be great!
> >>
> >>The code is still recovering from major surgery, but
> >>I think it is
> >>finally in a state where I think we can let the
> >>hacking begin! Sorry it
> >>took so long, but I was first in CVS hell, followed
> >>by jar hell and I
> >>did not want to subject anyone else to this. Anyhow,
> >>I still have the
> >>old code up on opentac.gmu.edu, so we can at least
> >>use that as a loose
> >>reference for the functional specs. The new code is
> >>still largely broken
> >>due to significant changes in the way user security
> >>is handled and also
> >>because of changes to the core schema
> >>(schema/project-schema.xml).
> >>
> >>What does you guys think about everyone choosing
> >>certain components of
> >>the code that you'll then "own?" We could almost go
> >>through
> >>struts-config.xml and just pick actions or groups of
> >>actions to work on.
> >>
> >>I think we should have a conference over IM so we
> >>can all discuss this
> >>in real time.
> >>
> >
> > Maybe it's better to use IRC (just saying this because
> > I don't use IM :-) ). And schedule it in some
> > timezone-independent time.
> >
> 
> I am fine with that. Can you or Arun arrange this?
> 
> --
> Seth Milder
> Department of Physics and Astronomy
> MS 3f3
> George Mason University
> Fairfax, VA
> --
> Heisenberg may have been here.
> 
> 
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
> Use IT products in your business? Tell us what you think of them. Give us
> Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
> http://productguide.itmanagersjournal.com/guidepromo.tmpl
> _______________________________________________
> Opentac2-developers mailing list
> Ope...@li...
> https://lists.sourceforge.net/lists/listinfo/opentac2-developers
>

Re: [Opentac2-developers] Agenda for OpenTAC2 developement

[James W. <jam...@gm...>]

Hi,
What JDK version should I be running maven against ?
Let me know what IM/IRC channel we are going to use - any time is fine
for me except 9-5 mon-fri UK time - have to be at work :(
Jim

Re: [Opentac2-developers] Agenda for OpenTAC2 developement

[Seth M. <mr...@ph...>]

James Williams wrote:
> Hi,
> What JDK version should I be running maven against ?
> Let me know what IM/IRC channel we are going to use - any time is fine
> for me except 9-5 mon-fri UK time - have to be at work :(
> Jim

I am using Sun's 1.4.2.

-- 
Seth Milder
Department of Physics and Astronomy
MS 3f3
George Mason University
Fairfax, VA
--
No nation is drunken where wine is cheap. THOMAS JEFFERSON 1818

Re: [Opentac2-developers] Agenda for OpenTAC2 developement

[Vlada D. <vla...@ya...>]

--- James Williams <jam...@gm...> wrote:

> Hi,
> What JDK version should I be running maven against ?
> Let me know what IM/IRC channel we are going to use
> - any time is fine
> for me except 9-5 mon-fri UK time - have to be at
> work :(
> Jim
> 
How about Monday, 9 or 10 PM, CET (GMT+1)?


		
_______________________________
Do you Yahoo!?
Declare Yourself - Register online to vote today!
http://vote.yahoo.com

Re: [Opentac2-developers] Agenda for OpenTAC2 developement

[Seth M. <mr...@ph...>]

Vlada Djurovic wrote:
> --- James Williams <jam...@gm...> wrote:
> 
> 
>>Hi,
>>What JDK version should I be running maven against ?
>>Let me know what IM/IRC channel we are going to use
>>- any time is fine
>>for me except 9-5 mon-fri UK time - have to be at
>>work :(
>>Jim
>>
> 
> How about Monday, 9 or 10 PM, CET (GMT+1)?
> 

I am GMT-4, so I think 9 CET would work for me, but I am trying to get 
to sleep a bit earlier so could 8:30PM CET work?

-- 
Seth Milder
Department of Physics and Astronomy
MS 3f3
George Mason University
Fairfax, VA
--
"In order to make an apple pie from scratch, you must first create the 
universe." -- Carl Sagan, Cosmos

Re: [Opentac2-developers] Agenda for OpenTAC2 developement

[Vlada D. <vla...@ya...>]

--- Seth Milder <mr...@ph...> wrote:

> Vlada Djurovic wrote:
> > --- James Williams <jam...@gm...>
> wrote:
> > 
> > 
> >>Hi,
> >>What JDK version should I be running maven against
> ?
> >>Let me know what IM/IRC channel we are going to
> use
> >>- any time is fine
> >>for me except 9-5 mon-fri UK time - have to be at
> >>work :(
> >>Jim
> >>
> > 
> > How about Monday, 9 or 10 PM, CET (GMT+1)?
> > 
> 
> I am GMT-4, so I think 9 CET would work for me, but
> I am trying to get 
> to sleep a bit earlier so could 8:30PM CET work?
> 

Fine by me. Anyone else?

> -- 
> Seth Milder
> Department of Physics and Astronomy
> MS 3f3
> George Mason University
> Fairfax, VA
> --
> "In order to make an apple pie from scratch, you
> must first create the 
> universe." -- Carl Sagan, Cosmos
> 
> 
>
-------------------------------------------------------
> This SF.net email is sponsored by: IT Product Guide
> on ITManagersJournal
> Use IT products in your business? Tell us what you
> think of them. Give us
> Your Opinions, Get Free ThinkGeek Gift Certificates!
> Click to find out more
>
http://productguide.itmanagersjournal.com/guidepromo.tmpl
> _______________________________________________
> Opentac2-developers mailing list
> Ope...@li...
>
https://lists.sourceforge.net/lists/listinfo/opentac2-developers
> 


=====
-------------
Vlada

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

Re: [Opentac2-developers] Agenda for OpenTAC2 developement

[Java C. <jav...@ya...>]

I'm GMT+5.30, So i may not available at that time ;)

--- Seth Milder <mr...@ph...> wrote:

> Vlada Djurovic wrote:
> > --- James Williams <jam...@gm...>
> wrote:
> > 
> > 
> >>Hi,
> >>What JDK version should I be running maven against
> ?
> >>Let me know what IM/IRC channel we are going to
> use
> >>- any time is fine
> >>for me except 9-5 mon-fri UK time - have to be at
> >>work :(
> >>Jim
> >>
> > 
> > How about Monday, 9 or 10 PM, CET (GMT+1)?
> > 
> 
> I am GMT-4, so I think 9 CET would work for me, but
> I am trying to get 
> to sleep a bit earlier so could 8:30PM CET work?
> 
> -- 
> Seth Milder
> Department of Physics and Astronomy
> MS 3f3
> George Mason University
> Fairfax, VA
> --
> "In order to make an apple pie from scratch, you
> must first create the 
> universe." -- Carl Sagan, Cosmos
> 
> 
>
-------------------------------------------------------
> This SF.net email is sponsored by: IT Product Guide
> on ITManagersJournal
> Use IT products in your business? Tell us what you
> think of them. Give us
> Your Opinions, Get Free ThinkGeek Gift Certificates!
> Click to find out more
>
http://productguide.itmanagersjournal.com/guidepromo.tmpl
> _______________________________________________
> Opentac2-developers mailing list
> Ope...@li...
>
https://lists.sourceforge.net/lists/listinfo/opentac2-developers
> 



		
_______________________________
Do you Yahoo!?
Declare Yourself - Register online to vote today!
http://vote.yahoo.com

Re: [Opentac2-developers] Agenda for OpenTAC2 developement

[James W. <jam...@gm...>]

What IRC channel ?

Re: [Opentac2-developers] Agenda for OpenTAC2 developement

[Seth M. <mr...@ph...>]

James Williams wrote:
> What IRC channel ?
> 

Yes, this is a good question!

Re: [Opentac2-developers] Agenda for OpenTAC2 developement

[Seth M. <mr...@ph...>]

Seth Milder wrote:

> James Williams wrote:
> 
>> What IRC channel ?
>>
> 
> Yes, this is a good question!
> 

Hello? Is this thing on?

:)

Re: [Opentac2-developers] Agenda for OpenTAC2 developement

[James W. <jam...@gm...>]

Oh well. We need to arrange a new time.
How about 8:30 p.m. GMT today (19th Oct) ?
Someone else please suggest an IRC channel as I don't use it often.
Or if you can't make that time we can change it.