Re: [Opentac2-developers] Notice

[Seth M. <mr...@ph...>]

Velja Radenkovic wrote:
> 1. File: preferences-content.jsp taglib declaration for
> struts-template.tld removed.
> Because it is unused and undeclared in web.xml.

Yes, I've moved to tiles now.

> 
> 2. Image on first page is spoiled. (Seth this one is addressed to you)
> 

I will fix it.


> 3. membership.jsp, This part should be better. 
> 

What do you suggest? I was going to rewrite this like I did 
src/WEB-INF/course/index_content.jsp. Should we use the el taglib to get 
rid of scriptlets? Or is there a better one?

> <logic:notEmpty name="KEY_USER" property="currentCourse.studentList">
>           <logic:iterate   name="KEY_USER"
> property="currentCourse.studentList" id="student"  indexId="i">
>              <% int color = i.intValue()%2; %>
>              <tr class="data<%=color%>">
>                 <td><html:multibox property="personId"
> value="<%=student.getId()%>"/></td>
>                 <td><a
> href="/opentac2/action/preferences.do?personId=<bean:write
> name="student" property="id"/>"><bean:write name="student"
> property="lastName"/></a></td>
>                 <td><a
> href="/opentac2/action/preferences.do?personId=<bean:write
> name="student" property="id"/>"><bean:write name="student"
> property="firstName"/></a></td>
>                 <td><a
> href="/opentac2/action/preferences.do?personId=<bean:write
> name="student" property="id"/>"><bean:write name="student"
> property="sid"/></a></td>
>                 <td><a
> href="/opentac2/action/preferences.do?personId=<bean:write
> name="student" property="id"/>"><bean:write name="student"
> property="email"/></a></td>
>                 <td><a
> href="/opentac2/action/preferences.do?personId=<bean:write
> name="student" property="id"/>"><bean:write name="student"
> property="active"/></a></td>
>              </tr>
>           </logic:iterate>
> </logic:notEmpty>   
> 
> 3. Because I know that I'm real pain in the ... I'll stop with "This
> is bad" and i'm starting the OpentacBoard module.
> Package: edu.gmu.opentac2.board
> JSPs: /WEB-INF/jsp/board
> struts-config for module: /WEB-INF/conf/struts-config-board.xml (Do
> not delete declaration in web.xml!)
> ApplicationResources: All content for board module ...
> #####################################################
> #################   Opentac2Board      ##################
> #####################################################
> after this.
> 
> 4. Added to web.xml (I need this because I am going to use standard fmt) 
> <context-param>
> 	<param-name>javax.servlet.jsp.jstl.fmt.localizationContext</param-name>
> 	<param-value>ApplicationResources</param-value>
>  </context-param>
> 
> 5. Added to Project.xml  (I need this because I am going to use standard fmt) 
> <dependency>
>   	      <groupId>taglibs</groupId>
>   	      <artifactId>fmt</artifactId>
>   	      <version>1.1.0</version>
>   	      <url>http://jakarta.apache.org/taglibs/</url>
>   	      <type>tld</type>
>   	      <properties>
>   	        <war.bundle>true</war.bundle>
>   	      </properties>
>   	</dependency>
> 


Also, everyone should add their own developer entry in project.xml and 
let me know if you do not have developer access to the project.


> 6. Please do not override those changes.Please consult me before
> changing enything in board module.
> 

Cool. You own it :)




-- 
Seth Milder
Department of Physics and Astronomy
MS 3f3
George Mason University
Fairfax, VA
--
The highest result of education is tolerance. HELEN KELLER