Menu
▾
▴
opensync-tickets
|
[Opensync-tickets] [libwbxml] #80: Very slow when parsing XML node
with lots of short lines of text.
From: libwbxml <ti...@op...> - 2012-05-10 07:39:50
|
#80: Very slow when parsing XML node with lots of short lines of text.
--------------------------+----------------------
Reporter: conrad.irwin | Owner: somebody
Type: issue | Status: new
Priority: important | Milestone:
Component: wbxml2 | Version: 0.11.0
Severity: other | Keywords:
--------------------------+----------------------
This is caused by the continual pre-pending of the entire text parsed so
far to the next line of input in wbxml_tree_add_node for adjacent text
nodes.
The example I came across was about 6MB of Base-64 encoded data arranged
into lines 76 bytes long, so it was copying the entire input around 100k
times which took a couple of minutes.
I've attached a patch that fixes this, and also changes the behaviour of
buffer reallocation to double in size each time the end of the buffer is
reached to reduce the potential number of copies that may need to be made
due to reallocation.
--
Ticket URL: <https://libwbxml.opensync.org/ticket/80>
libwbxml <http://libwbxml.opensync.org/>
WBXML Library
|
|
From: libwbxml <ti...@op...> - 2012-05-15 14:07:48
|
#80: Very slow when parsing XML node with lots of short lines of text.
--------------------------+-----------------------
Reporter: conrad.irwin | Owner: bellmich
Type: issue | Status: assigned
Priority: important | Milestone: 0.11.1
Component: wbxml2 | Version: 0.11.0
Severity: other | Resolution:
Keywords: |
--------------------------+-----------------------
Changes (by bellmich):
* owner: somebody => bellmich
* status: new => assigned
* milestone: => 0.11.1
Comment:
I will check the issue on Friday (2012-May-18).
--
Ticket URL: <https://libwbxml.opensync.org/ticket/80#comment:1>
libwbxml <http://libwbxml.opensync.org/>
WBXML Library
|
|
From: libwbxml <ti...@op...> - 2012-05-22 10:25:46
|
#80: Very slow when parsing XML node with lots of short lines of text.
--------------------------+-----------------------
Reporter: conrad.irwin | Owner: bellmich
Type: issue | Status: assigned
Priority: important | Milestone: 0.11.1
Component: wbxml2 | Version: 0.11.0
Severity: other | Resolution:
Keywords: |
--------------------------+-----------------------
Comment (by bellmich):
I think that the changes in wbxml_buffers.c makes the third parameter of
the function wbxml_buffer_create_real obsolete. The third parameter is
only used with the length of the data block itself.
What do you think?
--
Ticket URL: <https://libwbxml.opensync.org/ticket/80#comment:2>
libwbxml <http://libwbxml.opensync.org/>
WBXML Library
|
|
From: libwbxml <ti...@op...> - 2012-05-23 10:07:59
|
#80: Very slow when parsing XML node with lots of short lines of text.
--------------------------+-----------------------
Reporter: conrad.irwin | Owner: bellmich
Type: issue | Status: closed
Priority: important | Milestone: 0.11.1
Component: wbxml2 | Version: 0.11.0
Severity: other | Resolution: fixed
Keywords: |
--------------------------+-----------------------
Changes (by bellmich):
* status: assigned => closed
* resolution: => fixed
Comment:
I committed the patch as r333.
Additionally I committed a clean up patch as r334 to remove now useless
code.
--
Ticket URL: <https://libwbxml.opensync.org/ticket/80#comment:3>
libwbxml <http://libwbxml.opensync.org/>
WBXML Library
|
|
From: libwbxml <ti...@op...> - 2012-05-23 10:10:45
|
#80: Very slow when parsing XML node with lots of short lines of text.
--------------------------+-----------------------
Reporter: conrad.irwin | Owner: bellmich
Type: issue | Status: closed
Priority: important | Milestone: 0.11.1
Component: wbxml2 | Version: 0.11.0
Severity: other | Resolution: fixed
Keywords: |
--------------------------+-----------------------
Comment (by bellmich):
If you or your company/organization would like to be mentioned in the
ChangeLog or the release notes then please send me a notice.
Your email address will only be added to the source code repository if you
explicitly want this (to avoid spam).
--
Ticket URL: <https://libwbxml.opensync.org/ticket/80#comment:4>
libwbxml <http://libwbxml.opensync.org/>
WBXML Library
|
|
From: libwbxml <ti...@op...> - 2012-05-23 15:55:37
|
#80: Very slow when parsing XML node with lots of short lines of text.
--------------------------+-----------------------
Reporter: conrad.irwin | Owner: bellmich
Type: issue | Status: closed
Priority: important | Milestone: 0.11.1
Component: wbxml2 | Version: 0.11.0
Severity: other | Resolution: fixed
Keywords: |
--------------------------+-----------------------
Comment (by conrad.irwin):
Hi, r334 looks good; thanks for accepting the patches :).
Just being mentioned in the THANKS is good for me!
--
Ticket URL: <https://libwbxml.opensync.org/ticket/80#comment:5>
libwbxml <http://libwbxml.opensync.org/>
WBXML Library
|
|
From: libwbxml <ti...@op...> - 2012-05-23 16:03:43
|
#80: Very slow when parsing XML node with lots of short lines of text.
--------------------------+-----------------------
Reporter: conrad.irwin | Owner: bellmich
Type: issue | Status: closed
Priority: important | Milestone: 0.11.1
Component: wbxml2 | Version: 0.11.0
Severity: other | Resolution: fixed
Keywords: |
--------------------------+-----------------------
Comment (by bellmich):
libwbxml 0.11.1 is scheduled for Friday.
Thanks a lot for the good patches.
--
Ticket URL: <https://libwbxml.opensync.org/ticket/80#comment:6>
libwbxml <http://libwbxml.opensync.org/>
WBXML Library
|
Thanks for helping keep SourceForge clean.
X