opensync-devel

[Opensync-devel] snycml plugin

[deloptes <del...@ya...>]

To avoid this warning

opensync/libopensync-plugin-syncml/trunk/src/syncml_devinf.c: In
function ‘get_database_pref_content_type’:
opensync/libopensync-plugin-syncml/trunk/src/syncml_devinf.c:17: warning:
ordered comparison of pointer with integer zero
opensync/libopensync-plugin-syncml/trunk/src/syncml_devinf.c:23: warning:
ordered comparison of pointer with integer zero

I've changed this

        if (strstr(name, "21") > 0)
            ct = SML_ELEMENT_TEXT_VCARD;
        else
            ct = SML_ELEMENT_TEXT_VCARD_30;
    } else if (!strcmp(objtype, "event") ||
               !strcmp(objtype, "todo")) {
        if (strstr(name, "10") > 0)
            ct = SML_ELEMENT_TEXT_VCAL;
        else
            ct = SML_ELEMENT_TEXT_ICAL;

to

        if (sizeof(strstr(name, "21")) > 0)
            ct = SML_ELEMENT_TEXT_VCARD;
        else
            ct = SML_ELEMENT_TEXT_VCARD_30;
    } else if (!strcmp(objtype, "event") ||
               !strcmp(objtype, "todo")) {
        if (sizeof(strstr(name, "10")) > 0)
            ct = SML_ELEMENT_TEXT_VCAL;
        else
            ct = SML_ELEMENT_TEXT_ICAL;

regards

Re: [Opensync-devel] snycml plugin

[Tino K. <tin...@ti...>]

On Sat, Oct 16, 2010 at 10:31:01 +0200, deloptes wrote:
> To avoid this warning
> 
> opensync/libopensync-plugin-syncml/trunk/src/syncml_devinf.c: In
> function ‘get_database_pref_content_type’:
> opensync/libopensync-plugin-syncml/trunk/src/syncml_devinf.c:17: warning:
> ordered comparison of pointer with integer zero
> opensync/libopensync-plugin-syncml/trunk/src/syncml_devinf.c:23: warning:
> ordered comparison of pointer with integer zero
> 
> I've changed this
> 
>         if (strstr(name, "21") > 0)

[...]

> to
> 
>         if (sizeof(strstr(name, "21")) > 0)

This looks strange, if not broken. Why not consider the possible return
values of strstr() and do it like this?

if (strstr(name, "21") != NULL)

Regards,
Tino

Re: [Opensync-devel] snycml plugin

[deloptes <del...@ya...>]

Tino Keitel wrote:

> if (strstr(name, "21") != NULL)

you are right, this is much better.

regards

Re: [Opensync-devel] snycml plugin

[deloptes <del...@ya...>]

I have nokia 5530 to test sycml

syncml-ds-tool -b XX:XX:07:94:XX:XX 7 --wbxml --read-only --identifier "PC
Suite" --version "1.2" --sync text/x-vcard Contacts --wbxml

produces output

but nothing I can do for Calendar

Could someone give an example, please.

Re: [Opensync-devel] snycml plugin (progress)

[deloptes <del...@ya...>]

There is a proress but it seems something is not transformed properly. I'll
try to debug in near feature and see if Calendar would work too.

Received an entry 536 (xmlformat-contact) from member 1
(syncml-obex-client). Changetype ADDED
Received an entry 538 (xmlformat-contact) from member 1
(syncml-obex-client). Changetype ADDED
element Location: Schemas validity error : Element 'Location': Missing child
element(s). Expected is ( Longitude ).
ERROR: XMLFormat validation failed.
EXIT_ERROR: osync_converter_invoke: XMLFormat validation failed.
EXIT_ERROR: osync_format_env_convert: XMLFormat validation failed.
Main sink of member 1 of type syncml-obex-client had an error: XMLFormat
validation failed.
EXIT_ERROR: _osync_engine_receive_change: XMLFormat validation failed.
Received an entry 541 (xmlformat-contact) from member 1
(syncml-obex-client). Changetype ADDED
Received an entry 547 (xmlformat-contact) from member 1
(syncml-obex-client). Changetype ADDED
...
...
Received an entry 884 (xmlformat-contact) from member 1
(syncml-obex-client). Changetype ADDED
Received an entry 885 (xmlformat-contact) from member 1
(syncml-obex-client). Changetype ADDED
contact sink of member 1 of type syncml-obex-client just sent all changes
All clients sent changes or error
EXIT_ERROR: osync_status_conflict: Engine has an error. Sync got abortd?!
EXIT_ERROR: osync_mapping_engine_check_conflict
ERROR: Error while resolving conflicts
ERROR: At least one object engine failed while mapping changes. Aborting
ERROR: At least one object engine failed while mapping changes. Aborting
The sync failed: At least one object engine failed while mapping changes.
Aborting
ERROR: Engine aborting due to an error: At least one object engine failed
while mapping changes. Aborting
contact sink of member 1 of type syncml-obex-client just disconnected
contact sink of member 2 of type akonadi-sync just disconnected
Main sink of member 2 of type akonadi-sync just disconnected

regards