opensync-devel

[Opensync-devel] API behaviour change: osync_xmlformat_assemble (and heads-up to ldap plugin author)

[Chris F. <cd...@fo...>]

Hi,

I've made a memory allocation change to the function
osync_xmlformat_assemble() which can be viewed here:

http://repo.or.cz/w/opensync/opensync-cdf.git/commitdiff/b80405e0eafb0cebf1c034d9f08ceff778bf4fe3

Much of the code that I've seen, both inside the library and in the
plugins, assumes that the resulting buffer from a call to
osync_xmlformat_assemble() can be freed with osync_free() or g_free().

But the call passes back memory that expects to be freed with libxml2's
xmlFree().

If you're on a system that uses malloc everywhere, this might not matter,
but glib/gtk uses its own g_slice memory management, and this might
cause problems.

With the above commit, osync_xmlformat_assemble() gives back an osync_strdup()
buffer, so freeing works as expected.


scriptor:
	I've noticed in your ldap plugin code, you free this memory with
	calls to xmlFree(), which is very correct, but plugins shouldn't
	have to know this.  This change will affect you.

	Also, I notice that you make much use of valgrind in your testing.
	I've been fixing a lot of memory leaks in opensync in the above
	git repo.  If you'd like to give it a try and report back if you
	see any improvement, that would be great.

- Chris

Re: [Opensync-devel] API behaviour change: osync_xmlformat_assemble (and heads-up to ldap plugin author)

[Juergen L. <jue...@gm...>]

On Fri, Jul 22, 2011 at 06:40:37PM -0400, Chris Frey wrote:

(...) 

> 	I've noticed in your ldap plugin code, you free this memory with
> 	calls to xmlFree(), which is very correct, but plugins shouldn't
> 	have to know this.  This change will affect you.

Done.

> 	Also, I notice that you make much use of valgrind in your testing.
> 	I've been fixing a lot of memory leaks in opensync in the above
> 	git repo.  If you'd like to give it a try and report back if you
> 	see any improvement, that would be great.

Yes, of course.  Right now I run the tests without valgrind, and
I face some unexpected issues.  

Anyway - great to see some progress in libopensync. 
Thank you very much, indeed.

Bye, bye 

Juergen