opensync-devel

[Opensync-devel] Gnokii patch

[Quentin D. <que...@gm...>]

Here is a patch to make the gnokii plugin compile against the latest api. 
However, the plugin does not register yet and there are still warnings during 
compilation but I think this patch is a good starting point. Could anyone 
commit the changes since I have no access to svn?

There are also a sink and an easy slowsync issue to solve in gnokii_contacts.c 
(and the same for gnokii_calendar.c) but before being able to fix this I would 
need two questions answered:

1. what is exactly a sink object and what is the concept behind it? Just a two 
lines explaination please, I have a vague idea...

2. it's my first time I code in C, but do the functions have to respond to a 
particular constructor? Take the example of this outdated one:

void gnokii_calendar_get_changes(void *plugindata, OSyncPluginInfo *info, 
OSyncContext *ctx)

which is only called by: 
osync_objtype_sink_set_get_changes_func(event_sinkenv->sink, 
gnokii_calendar_get_changes);

no argument is passed, to I suppose it tells the engine to call the function 
and to pass itself the required arguments? Hence the need to use a certain 
standard constructor that I would have to take over from say the file-sync 
plugin.

There are also some objformat issues in that file, but I will try hard to 
solve them lateron if nobody is willing to apply his/her expertise easily and 
quickly. ;)

Best regards,
Quentin (falling back on gnokii because of syncml issue: Ticket #1267)

Re: [Opensync-devel] Gnokii patch

[Emanoil K. <del...@ya...>]

Hi, I could do the check in and have a look into the plugin.
I prefer c++ but in C were the first lesson in serious programming that I had back in 1990 ...

If you are familiar with object oriented programming (I think you are) and C++ think of C as if objects (C++) are structures (C) and methods (C++) are loose functions (C) so that everything in C is a function besides structures and variables. I hope this brief info helps you understand it.

Thank you for looking for alternatives I was wondering what this gnkokii thing was all about.

--- On Sat, 1/8/11, Quentin Denis <que...@gm...> wrote:

> There are also a sink and an easy slowsync issue to solve
> in gnokii_contacts.c 
> (and the same for gnokii_calendar.c) but before being able
> to fix this I would 
> need two questions answered:
> 
> 1. what is exactly a sink object and what is the concept
> behind it? Just a two 
> lines explaination please, I have a vague idea...

you can have one sync object type per config (notes, contacts, calendar and todo)

those are paired with the equivalent obj type on the other end(s)/plugin(s)

you assign one or more formats to an obj (like vtodo10/20 etc) on each side and the syncengine is doing the conversion and the sync between for you.

> 
> 2. it's my first time I code in C, but do the functions
> have to respond to a 
> particular constructor? Take the example of this outdated
> one:
> 
> void gnokii_calendar_get_changes(void *plugindata,
> OSyncPluginInfo *info, 
> OSyncContext *ctx)
> 
> which is only called by: 
> osync_objtype_sink_set_get_changes_func(event_sinkenv->sink,
> 
> gnokii_calendar_get_changes);

no, this way you assign a custom function to the object (in this case event_sinkenv->sink is associated with gnokii_calendar_get_changes) The code takes care for passing the right arguments to the function when called

> 
> no argument is passed, to I suppose it tells the engine to
> call the function 
> and to pass itself the required arguments? Hence the need
> to use a certain 
> standard constructor that I would have to take over from
> say the file-sync 
> plugin.

you can follow/borrow from this or any other ... the problem is in the details

> 
> There are also some objformat issues in that file, but I
> will try hard to 
> solve them lateron if nobody is willing to apply his/her
> expertise easily and 
> quickly. ;)
> 
> Best regards,
> Quentin (falling back on gnokii because of syncml issue:
> Ticket #1267)
> 

So your plan is to use gnokii with akonadi?

thanks and kind regards


      

Re: [Opensync-devel] Gnokii patch

[deloptes <del...@ya...>]

Emanoil Kotsev wrote:

> Hi, I could do the check in and have a look into the plugin.
> I prefer c++ but in C were the first lesson in serious programming that I
> had back in 1990 ...
> 
> If you are familiar with object oriented programming (I think you are) and
> C++ think of C as if objects (C++) are structures (C) and methods (C++)
> are loose functions (C) so that everything in C is a function besides
> structures and variables. I hope this brief info helps you understand it.
> 
> Thank you for looking for alternatives I was wondering what this gnkokii
> thing was all about.


sorry I couldn't apply the patch

Username: deloptes
Password for 'deloptes':
Sending        src/gnokii_calendar_format.c
svn: Commit failed (details follow):
svn: Server sent unexpected return value (403 Forbidden) in response to
CHECKOUT request
for '/!svn/ver/5638/plugins/gnokii-sync/src/gnokii_calendar_format.c'
svn: Your commit message was left in a temporary file:
svn:    '/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/svn-commit.3.tmp'

I was thinking one could commit in any plugin

regards

Re: [Opensync-devel] Gnokii patch

[Emanoil K. <del...@ya...>]

Quentin Denis wrote:

> Here is a patch to make the gnokii plugin compile against the latest api.
> However, the plugin does not register yet and there are still warnings
> during compilation but I think this patch is a good starting point. Could
> anyone commit the changes since I have no access to svn?

I couldn't apply the patch, but I had a look into the code and the messages below

it looks like the code does not fit the recent gnokii*.h definitions, so much more needs to be done.

Daniel, do you intend to work on the code in (near) future?

gnokii could provide contact and calendar sync  (if we are lucky).

Does someone know if it would work with symbian?

here the warnings

/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_config.c: In function ‘gnokii_config_parse’:
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_config.c:173: warning: ‘gn_cfg_memory_read’ is deprecated (declared at /usr/include/gnokii.h:266)
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_config.c:173: warning: passing argument 1 of ‘gn_cfg_memory_read’ from incompatible pointer type
/usr/include/gnokii.h:266: note: expected ‘const char **’ but argument is of type ‘char **’
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_config.c:174: warning: ‘gn_cfg_phone_load’ is deprecated (declared at /usr/include/gnokii.h:273)
[ 77%] Building C object src/CMakeFiles/gnokii-sync.dir/gnokii_sync.o
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.c: In function ‘initialize’:
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.c:199: warning: passing argument 2 of ‘osync_objtype_sink_set_connect_func’ from incompatible pointer type
/opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtype_sink.h:615: note: expected ‘OSyncSinkConnectFn’ but argument is of type ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *)’
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.c:200: warning: passing argument 2 of ‘osync_objtype_sink_set_disconnect_func’ from incompatible pointer type
/opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtype_sink.h:629: note: expected ‘OSyncSinkDisconnectFn’ but argument is of type ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *)’
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.c:215: warning: passing argument 2 of ‘osync_objtype_sink_set_get_changes_func’ from incompatible pointer type
/opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtype_sink.h:617: note: expected ‘OSyncSinkGetChangesFn’ but argument is of type ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *)’
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.c:216: warning: passing argument 2 of ‘osync_objtype_sink_set_commit_func’ from incompatible pointer type
/opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtype_sink.h:619: note: expected ‘OSyncSinkCommitFn’ but argument is of type ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *, struct OSyncChange *)’
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.c:217: warning: passing argument 2 of ‘osync_objtype_sink_set_sync_done_func’ from incompatible pointer type
/opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtype_sink.h:625: note: expected ‘OSyncSinkSyncDoneFn’ but argument is of type ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *)’
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.c:248: warning: passing argument 2 of ‘osync_objtype_sink_set_get_changes_func’ from incompatible pointer type
/opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtype_sink.h:617: note: expected ‘OSyncSinkGetChangesFn’ but argument is of type ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *)’
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.c:249: warning: passing argument 2 of ‘osync_objtype_sink_set_commit_func’ from incompatible pointer type
/opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtype_sink.h:619: note: expected ‘OSyncSinkCommitFn’ but argument is of type ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *, struct OSyncChange *)’
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.c:250: warning: passing argument 2 of ‘osync_objtype_sink_set_sync_done_func’ from incompatible pointer type
/opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtype_sink.h:625: note: expected ‘OSyncSinkSyncDoneFn’ but argument is of type ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *)’
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.c: In function ‘get_sync_info’:
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.c:296: warning: passing argument 2 of ‘osync_plugin_set_discover’ from incompatible pointer type
/opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_plugin.h:237: note: expected ‘discover_fn’ but argument is of type ‘osync_bool (*)(void *, struct OSyncPluginInfo *, struct OSyncError **)’
[ 88%] Building C object src/CMakeFiles/gnokii-sync.dir/gnokii_calendar.o
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_calendar.c: In function ‘gnokii_calendar_get_changes’:
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_calendar.c:345: warning: initialization makes pointer from integer without a cast
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_calendar.c:355: warning: initialization makes pointer from integer without a cast
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_calendar.c: In function ‘gnokii_calendar_commit_change’:
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_calendar.c:476: warning: initialization makes pointer from integer without a cast
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_calendar.c:477: warning: initialization makes pointer from integer without a cast
[100%] Building C object src/CMakeFiles/gnokii-sync.dir/gnokii_contact.o
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_contact.c: In function ‘gnokii_contact_get_changes’:
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_contact.c:393: warning: initialization makes pointer from integer without a cast
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_contact.c:396: warning: initialization makes pointer from integer without a cast
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_contact.c: In function ‘gnokii_contact_commit_change’:
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_contact.c:562: warning: initialization makes pointer from integer without a cast
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_contact.c:563: warning: initialization makes pointer from integer without a cast
Linking C shared module gnokii-sync.so
[100%] Built target gnokii-sync                                                 


      

Re: [Opensync-devel] Gnokii patch

[Quentin D. <que...@gm...>]

I am aware of those warnings, but I though that fixing the plugin api was a 
good start.

I don't know if Daniel will update his plugin. I have already asked him but 
absence of response pushed me to have a look at the code by myself. He 
certainly has a better knowledge of the gnokii api and would fix it much 
faster than I would. However, in my desperate case of syncing my phone I saw 
this opportunity as being a good start to learn about plugins and maybe write  
my own gammu plugin later on (I know a bit about its api because of 
kmobiletools).

Symbian phones:
http://www.gnokii.org/docs.shtml#symbian
Gammu does not do much better:
http://wammu.eu/docs/faq/#symbian
because of a lack of C++ knowledge 
(http://blog.cihar.com/archives/2007/06/27/gammu_and_symbian_3rd_generation/)

On Monday 10 January 2011 21:30:43 Emanoil Kotsev wrote:
> Quentin Denis wrote:
> > Here is a patch to make the gnokii plugin compile against the latest api.
> > However, the plugin does not register yet and there are still warnings
> > during compilation but I think this patch is a good starting point. Could
> > anyone commit the changes since I have no access to svn?
> 
> I couldn't apply the patch, but I had a look into the code and the messages
> below
> 
> it looks like the code does not fit the recent gnokii*.h definitions, so
> much more needs to be done.
> 
> Daniel, do you intend to work on the code in (near) future?
> 
> gnokii could provide contact and calendar sync  (if we are lucky).
> 
> Does someone know if it would work with symbian?
> 
> here the warnings
> 
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_config
> .c: In function ‘gnokii_config_parse’:
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_confi
> g.c:173: warning: ‘gn_cfg_memory_read’ is deprecated (declared at
> /usr/include/gnokii.h:266)
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_confi
> g.c:173: warning: passing argument 1 of ‘gn_cfg_memory_read’ from
> incompatible pointer type /usr/include/gnokii.h:266: note: expected ‘const
> char **’ but argument is of type ‘char **’
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_confi
> g.c:174: warning: ‘gn_cfg_phone_load’ is deprecated (declared at
> /usr/include/gnokii.h:273) [ 77%] Building C object
> src/CMakeFiles/gnokii-sync.dir/gnokii_sync.o
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.
> c: In function ‘initialize’:
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.
> c:199: warning: passing argument 2 of ‘osync_objtype_sink_set_connect_func’
> from incompatible pointer type
> /opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtyp
> e_sink.h:615: note: expected ‘OSyncSinkConnectFn’ but argument is of type
> ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *)’
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.
> c:200: warning: passing argument 2 of
> ‘osync_objtype_sink_set_disconnect_func’ from incompatible pointer type
> /opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtyp
> e_sink.h:629: note: expected ‘OSyncSinkDisconnectFn’ but argument is of
> type ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *)’
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.
> c:215: warning: passing argument 2 of
> ‘osync_objtype_sink_set_get_changes_func’ from incompatible pointer type
> /opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtyp
> e_sink.h:617: note: expected ‘OSyncSinkGetChangesFn’ but argument is of
> type ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *)’
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.
> c:216: warning: passing argument 2 of ‘osync_objtype_sink_set_commit_func’
> from incompatible pointer type
> /opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtyp
> e_sink.h:619: note: expected ‘OSyncSinkCommitFn’ but argument is of type
> ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *, struct
> OSyncChange *)’
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.
> c:217: warning: passing argument 2 of
> ‘osync_objtype_sink_set_sync_done_func’ from incompatible pointer type
> /opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtyp
> e_sink.h:625: note: expected ‘OSyncSinkSyncDoneFn’ but argument is of type
> ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *)’
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.
> c:248: warning: passing argument 2 of
> ‘osync_objtype_sink_set_get_changes_func’ from incompatible pointer type
> /opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtyp
> e_sink.h:617: note: expected ‘OSyncSinkGetChangesFn’ but argument is of
> type ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *)’
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.
> c:249: warning: passing argument 2 of ‘osync_objtype_sink_set_commit_func’
> from incompatible pointer type
> /opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtyp
> e_sink.h:619: note: expected ‘OSyncSinkCommitFn’ but argument is of type
> ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *, struct
> OSyncChange *)’
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.
> c:250: warning: passing argument 2 of
> ‘osync_objtype_sink_set_sync_done_func’ from incompatible pointer type
> /opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtyp
> e_sink.h:625: note: expected ‘OSyncSinkSyncDoneFn’ but argument is of type
> ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *)’
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.
> c: In function ‘get_sync_info’:
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.
> c:296: warning: passing argument 2 of ‘osync_plugin_set_discover’ from
> incompatible pointer type
> /opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_plugin
> .h:237: note: expected ‘discover_fn’ but argument is of type ‘osync_bool
> (*)(void *, struct OSyncPluginInfo *, struct OSyncError **)’ [ 88%]
> Building C object src/CMakeFiles/gnokii-sync.dir/gnokii_calendar.o
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_calen
> dar.c: In function ‘gnokii_calendar_get_changes’:
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_calen
> dar.c:345: warning: initialization makes pointer from integer without a
> cast
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_calen
> dar.c:355: warning: initialization makes pointer from integer without a
> cast
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_calen
> dar.c: In function ‘gnokii_calendar_commit_change’:
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_calen
> dar.c:476: warning: initialization makes pointer from integer without a
> cast
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_calen
> dar.c:477: warning: initialization makes pointer from integer without a
> cast [100%] Building C object
> src/CMakeFiles/gnokii-sync.dir/gnokii_contact.o
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_conta
> ct.c: In function ‘gnokii_contact_get_changes’:
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_conta
> ct.c:393: warning: initialization makes pointer from integer without a cast
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_conta
> ct.c:396: warning: initialization makes pointer from integer without a cast
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_conta
> ct.c: In function ‘gnokii_contact_commit_change’:
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_conta
> ct.c:562: warning: initialization makes pointer from integer without a cast
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_conta
> ct.c:563: warning: initialization makes pointer from integer without a cast
> Linking C shared module gnokii-sync.so
> [100%] Built target gnokii-sync

Re: [Opensync-devel] Gnokii patch

[Emanoil K. <del...@ya...>]

Ok thanks for the research, I thought you have exams :-). Focus on them!

--- On Mon, 1/10/11, Quentin Denis <que...@gm...> wrote:

> Date: Monday, January 10, 2011, 10:17 PM
> I am aware of those warnings, but I
> though that fixing the plugin api was a 
> good start.

start to where is teh question - it looks to me like a dead end! 

That much on free software :D I still cant believe that no one is syncing his f**king phone with linux ... or what kind of phones are using those guys. I was using siemens c or s55 - great phone it was syncing well untill it fall appart after 4 years of use, then the dark ages started for me. I had nokia and business phone sonyerr that I couldn't sync with each other because of incompatibility if the property fields ... and I've got constantly double entries. I gave it up and focused on writing my thesis. 2years ago I was done and last year came to this project, because, now, the smart phones are on the market over two years and .... no one is syncing. I don't want to believe this - really!

> 
> I don't know if Daniel will update his plugin. I have
> already asked him but 
> absence of response pushed me to have a look at the code by
> myself. He 
> certainly has a better knowledge of the gnokii api and
> would fix it much 
> faster than I would. However, in my desperate case of
> syncing my phone I saw 
> this opportunity as being a good start to learn about
> plugins and maybe write  
> my own gammu plugin later on (I know a bit about its api
> because of 
> kmobiletools).
> 
> Symbian phones:
> http://www.gnokii.org/docs.shtml#symbian
> Gammu does not do much better:
> http://wammu.eu/docs/faq/#symbian
> because of a lack of C++ knowledge 
> (http://blog.cihar.com/archives/2007/06/27/gammu_and_symbian_3rd_generation/)
> 

I would prefer to focus on one thing at a time. we are busy anyway. Perhaps it's much better to support Michael to fix the syncml and for you it would be probably better to work on the kitchensync, so that configure can work from the gui. I could also help here and there.

If any one is successfully using osynctool for syncing a phone with kde3 or 4, please, give me an example? By phone I mean something that went on the market in the past 2 years

thanks and regards



      

Re: [Opensync-devel] Gnokii patch

[Pawel K. <paw...@gm...>]

Hi,

On Mon, Jan 10, 2011 at 21:30, Emanoil Kotsev <del...@ya...> wrote:
> Quentin Denis wrote:
>
>> Here is a patch to make the gnokii plugin compile against the latest api.
>> However, the plugin does not register yet and there are still warnings
>> during compilation but I think this patch is a good starting point. Could
>> anyone commit the changes since I have no access to svn?
>
> I couldn't apply the patch, but I had a look into the code and the messages below
>
> it looks like the code does not fit the recent gnokii*.h definitions, so much more needs to be done.

I do not think a lot has changed in gnokii API. There were indeed some
changes but nothing that would prevent gnokii plugin from working. In
any case I'm happy to assist you with updates or make gnokii API more
useful to you.

take care,
-- 
Pawel Kot

Re: [Opensync-devel] Gnokii patch

[Quentin D. <que...@gm...>]

Ok, from the compilation output I can deduce the following:

1st part: gnokii api changes: Pawel, how does the whole config work now? I 
can't find any documentation about this on google, all I find out is that's 
deprecated (but still working?). Btw, there is a dead link to the wiki on the 
gnokii homepage, discovered that as I was looking for documentation

2nd part: OSyncSink issues in the plugin. I don't know how to fix this yet

3rd part: the issues I mentioned in my first mail with calendar and contacts: 
objformat and so on in the commit/get_changes functions. I have looked at 
other plugins how to solve it but I would need someone to revise patches I 
would provide later on.

Small bracket on SyncML: Emanoil, you know my issue with SyncML. I would be 
glad to provide the necessary information to solve that issue, and if I could 
I would even lend you my phone, but I am technically not able to fix the 
syncml code.

Regards,
Quentin

On Monday 10 January 2011 21:30:43 Emanoil Kotsev wrote:
> Quentin Denis wrote:
> > Here is a patch to make the gnokii plugin compile against the latest api.
> > However, the plugin does not register yet and there are still warnings
> > during compilation but I think this patch is a good starting point. Could
> > anyone commit the changes since I have no access to svn?
> 
> I couldn't apply the patch, but I had a look into the code and the messages
> below
> 
> it looks like the code does not fit the recent gnokii*.h definitions, so
> much more needs to be done.
> 
> Daniel, do you intend to work on the code in (near) future?
> 
> gnokii could provide contact and calendar sync  (if we are lucky).
> 
> Does someone know if it would work with symbian?
> 
> here the warnings
> 
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_config
> .c: In function ‘gnokii_config_parse’:
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_confi
> g.c:173: warning: ‘gn_cfg_memory_read’ is deprecated (declared at
> /usr/include/gnokii.h:266)
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_confi
> g.c:173: warning: passing argument 1 of ‘gn_cfg_memory_read’ from
> incompatible pointer type /usr/include/gnokii.h:266: note: expected ‘const
> char **’ but argument is of type ‘char **’
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_confi
> g.c:174: warning: ‘gn_cfg_phone_load’ is deprecated (declared at
> /usr/include/gnokii.h:273) [ 77%] Building C object
> src/CMakeFiles/gnokii-sync.dir/gnokii_sync.o
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.
> c: In function ‘initialize’:
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.
> c:199: warning: passing argument 2 of ‘osync_objtype_sink_set_connect_func’
> from incompatible pointer type
> /opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtyp
> e_sink.h:615: note: expected ‘OSyncSinkConnectFn’ but argument is of type
> ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *)’
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.
> c:200: warning: passing argument 2 of
> ‘osync_objtype_sink_set_disconnect_func’ from incompatible pointer type
> /opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtyp
> e_sink.h:629: note: expected ‘OSyncSinkDisconnectFn’ but argument is of
> type ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *)’
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.
> c:215: warning: passing argument 2 of
> ‘osync_objtype_sink_set_get_changes_func’ from incompatible pointer type
> /opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtyp
> e_sink.h:617: note: expected ‘OSyncSinkGetChangesFn’ but argument is of
> type ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *)’
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.
> c:216: warning: passing argument 2 of ‘osync_objtype_sink_set_commit_func’
> from incompatible pointer type
> /opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtyp
> e_sink.h:619: note: expected ‘OSyncSinkCommitFn’ but argument is of type
> ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *, struct
> OSyncChange *)’
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.
> c:217: warning: passing argument 2 of
> ‘osync_objtype_sink_set_sync_done_func’ from incompatible pointer type
> /opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtyp
> e_sink.h:625: note: expected ‘OSyncSinkSyncDoneFn’ but argument is of type
> ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *)’
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.
> c:248: warning: passing argument 2 of
> ‘osync_objtype_sink_set_get_changes_func’ from incompatible pointer type
> /opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtyp
> e_sink.h:617: note: expected ‘OSyncSinkGetChangesFn’ but argument is of
> type ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *)’
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.
> c:249: warning: passing argument 2 of ‘osync_objtype_sink_set_commit_func’
> from incompatible pointer type
> /opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtyp
> e_sink.h:619: note: expected ‘OSyncSinkCommitFn’ but argument is of type
> ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *, struct
> OSyncChange *)’
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.
> c:250: warning: passing argument 2 of
> ‘osync_objtype_sink_set_sync_done_func’ from incompatible pointer type
> /opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_objtyp
> e_sink.h:625: note: expected ‘OSyncSinkSyncDoneFn’ but argument is of type
> ‘void (*)(void *, struct OSyncPluginInfo *, struct OSyncContext *)’
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.
> c: In function ‘get_sync_info’:
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_sync.
> c:296: warning: passing argument 2 of ‘osync_plugin_set_discover’ from
> incompatible pointer type
> /opt/testing/opensync/include/libopensync1/opensync/plugin/opensync_plugin
> .h:237: note: expected ‘discover_fn’ but argument is of type ‘osync_bool
> (*)(void *, struct OSyncPluginInfo *, struct OSyncError **)’ [ 88%]
> Building C object src/CMakeFiles/gnokii-sync.dir/gnokii_calendar.o
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_calen
> dar.c: In function ‘gnokii_calendar_get_changes’:
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_calen
> dar.c:345: warning: initialization makes pointer from integer without a
> cast
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_calen
> dar.c:355: warning: initialization makes pointer from integer without a
> cast
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_calen
> dar.c: In function ‘gnokii_calendar_commit_change’:
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_calen
> dar.c:476: warning: initialization makes pointer from integer without a
> cast
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_calen
> dar.c:477: warning: initialization makes pointer from integer without a
> cast [100%] Building C object
> src/CMakeFiles/gnokii-sync.dir/gnokii_contact.o
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_conta
> ct.c: In function ‘gnokii_contact_get_changes’:
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_conta
> ct.c:393: warning: initialization makes pointer from integer without a cast
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_conta
> ct.c:396: warning: initialization makes pointer from integer without a cast
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_conta
> ct.c: In function ‘gnokii_contact_commit_change’:
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_conta
> ct.c:562: warning: initialization makes pointer from integer without a cast
> /home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_conta
> ct.c:563: warning: initialization makes pointer from integer without a cast
> Linking C shared module gnokii-sync.so
> [100%] Built target gnokii-sync

Re: [Opensync-devel] Gnokii patch

[Emanoil K. <del...@ya...>]

Hi,

--- On Tue, 1/11/11, Quentin Denis <que...@gm...> wrote:

> 
> 1st part: gnokii api changes: Pawel, how does the whole
> config work now? I 
> can't find any documentation about this on google, all I
> find out is that's 
> deprecated (but still working?). Btw, there is a dead link
> to the wiki on the 
> gnokii homepage, discovered that as I was looking for
> documentation
> 
> 2nd part: OSyncSink issues in the plugin. I don't know how
> to fix this yet
> 
> 3rd part: the issues I mentioned in my first mail with
> calendar and contacts: 
> objformat and so on in the commit/get_changes functions. I
> have looked at 
> other plugins how to solve it but I would need someone to
> revise patches I 
> would provide later on.

It's probably the same as for the akonadi and the other plugins that need to fit the new osync api. if you need an assistance - let me know.

> 
> Small bracket on SyncML: Emanoil, you know my issue with
> SyncML. I would be 
> glad to provide the necessary information to solve that
> issue, and if I could 
> I would even lend you my phone, but I am technically not
> able to fix the 
> syncml code.
> 

I'm sorry but I have already forgotten what your problem with syncml was - sorry but I was fixed on my one.

regards


      

Re: [Opensync-devel] Gnokii patch

[Pawel K. <paw...@gm...>]

Hi Quentin,

On Tue, Jan 11, 2011 at 10:02, Quentin Denis <que...@gm...> wrote:
> 1st part: gnokii api changes: Pawel, how does the whole config work now? I

Actually there's no change in here. There are new (better?) functions
to handle this which should give more flexibility. Still the old one
works and will work for some more time.

> can't find any documentation about this on google, all I find out is that's
> deprecated (but still working?). Btw, there is a dead link to the wiki on the
> gnokii homepage, discovered that as I was looking for documentation

Yes, wiki is down now unfortunately. I will look in detail on the
current code in the plugin and will propose non-deprecated solution.

take care,
-- 
Pawel Kot

Re: [Opensync-devel] Gnokii patch

[Quentin D. <que...@gm...>]

Hi folks,

may I ask you to verify this patch? Emanoil, do you now have access to commit 
into the gnokii directory in SVN?

With this patch I removed all the warnings, except the ones related to the 
calendar support. Once you have approved my contact changes, I will apply them 
on calendar since it's the same code.

However, the plugin still not listed in osynctool. I am wondering if this is 
because of the remaining warnings (only related to calendar then) or because 
something fundamental is missing. Any idea?

I think most of the changes should be correct, but I would like to catch your 
attention to the modifcations I did in the get/commit_changes functions 
(gnokii_contact.c) with all the sink and format stuff changes. Please make 
sure everything is okay there.

Best regards,
Quentin

On Tuesday 11 January 2011 12:32:49 Pawel Kot wrote:
> Hi Quentin,
> 
> On Tue, Jan 11, 2011 at 10:02, Quentin Denis <que...@gm...> 
wrote:
> > 1st part: gnokii api changes: Pawel, how does the whole config work now?
> > I
> 
> Actually there's no change in here. There are new (better?) functions
> to handle this which should give more flexibility. Still the old one
> works and will work for some more time.
> 
> > can't find any documentation about this on google, all I find out is
> > that's deprecated (but still working?). Btw, there is a dead link to the
> > wiki on the gnokii homepage, discovered that as I was looking for
> > documentation
> 
> Yes, wiki is down now unfortunately. I will look in detail on the
> current code in the plugin and will propose non-deprecated solution.
> 
> take care,

Re: [Opensync-devel] Gnokii patch

[Daniel G. <go...@b1...>]

On Saturday, January 15, 2011 12:59:27 pm Quentin Denis wrote:
> Hi folks,
> 
> may I ask you to verify this patch?

Sure, sorry for the delay - was laid low with the flu.


> Emanoil, do you now have access to
> commit into the gnokii directory in SVN?

I can give you commit access if you like.
Just let me know your trac-user name (once again).


> 
> With this patch I removed all the warnings, except the ones related to the
> calendar support. Once you have approved my contact changes, I will apply
> them on calendar since it's the same code.
> 
> However, the plugin still not listed in osynctool. I am wondering if this
> is because of the remaining warnings (only related to calendar then) or
> because something fundamental is missing. Any idea?

Tip how to root-cause such problems:

Run: OSYNC_TRACE=/tmp/osync_trace/ OSYNC_PRINTERROR=1 osynctool --listplugins


Applied your patch (gnokii2.patch)

dgollub@marvin:~/projects/OpenSync/plugins/gnokii-sync/build> OSYNC_TRACE=/tmp/osync_trace/ OSYNC_PRINTERROR=1 osynctool --
listplugins
ERROR: Unable to open module /home/dgollub/build/OpenSync/lib/libopensync1/plugins/gnokii-sync.so: 
/home/dgollub/build/OpenSync/lib/libopensync1/plugins/gnokii-sync.so: undefined symbol: osync_objtype_sink_get_slowsync
EXIT_ERROR: osync_module_load: Unable to open module /home/dgollub/build/OpenSync/lib/libopensync1/plugins/gnokii-sync.so: 
/home/dgollub/build/OpenSync/lib/libopensync1/plugins/gnokii-sync.so: undefined symbol: osync_objtype_sink_get_slowsync


[...]

-- 
Daniel Gollub
Linux Consultant & Developer
Tel.: +49-160 47 73 970 
Mail: go...@b1...

B1 Systems GmbH
Osterfeldstraße 7 / 85088 Vohburg / http://www.b1-systems.de
GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537

Re: [Opensync-devel] Gnokii patch

[deloptes <del...@ya...>]

Quentin Denis wrote:

> Hi folks,
> 
> may I ask you to verify this patch? Emanoil, do you now have access to
> commit into the gnokii directory in SVN?

Don't know, but I've updated from svn, and it seems that David ( according
svn log ) applied last changes

> 
> With this patch I removed all the warnings, except the ones related to the
> calendar support. Once you have approved my contact changes, I will apply
> them on calendar since it's the same code.
> 
> However, the plugin still not listed in osynctool. I am wondering if this
> is because of the remaining warnings (only related to calendar then) or
> because something fundamental is missing. Any idea?

For me it is now

osynctool --listplugins
Available plugins:
file-sync
evo2-sync
akonadi-sync
syncml-http-server
syncml-http-client
syncml-obex-client
gnokii-sync


> 
> I think most of the changes should be correct, but I would like to catch
> your attention to the modifcations I did in the get/commit_changes
> functions (gnokii_contact.c) with all the sink and format stuff changes.
> Please make sure everything is okay there.
> 

I still get this warning

/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_config.c:
In function ‘gnokii_config_parse’:
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_config.c:173:
warning: ‘gn_cfg_memory_read’ is deprecated (declared
at /usr/include/gnokii.h:266)
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_config.c:173:
warning: passing argument 1 of ‘gn_cfg_memory_read’ from incompatible
pointer type
/usr/include/gnokii.h:266: note: expected ‘const char **’ but argument is of
type ‘char **’
/home/yoki/opensync/libopensync-plugin-gnokii/gnokii-sync/src/gnokii_config.c:174:
warning: ‘gn_cfg_phone_load’ is deprecated (declared
at /usr/include/gnokii.h:273)

regards