|
From: Chris F. <cd...@fo...> - 2010-09-18 02:57:13
|
On Sat, Aug 14, 2010 at 12:22:10PM +1200, Daniel Gollub wrote: > And so far we only have one single svn:externals - and it's just for the cmake > modules. Yeah, it's sad that this breaks git and others ... but the cmake- > modules doesn't change that often. Actually we introduced that due to the fact > that cmake and it's modules were still in a very early stage of development. > So we had to write a couple of cmake modules by our own to find buliding > depencies ... i guess some modules find their way already in recent cmake > versions which already packaged in recent distribution. So we could think of > getting replacing svn:externals by merging the changed modules - if required. > > How does that sounds to you? > You might wanna try this for those repositories you're actively using - e.g. > opensync, osynctool(?), google-calendar, file-sync, ... so you can use for > those at least a git bridge. I'm about ready to give this a try... the alternatives are nearly making me pull my hair out. :-) Does anyone object if I remove the svn:externals propset in the following repos and replace them with the latest cmake modules? opensync osynctool file-sync google-calendar evolution2 vformat xmlformat xsltformat I can do the same work on other plugins if anyone wants me to. Thanks, - Chris |
|
From: Daniel G. <go...@b1...> - 2010-09-18 07:13:35
|
On Saturday, September 18, 2010 02:57:03 pm Chris Frey wrote: > Does anyone object if I remove the svn:externals propset in the following > repos and replace them with the latest cmake modules? > > opensync > osynctool > file-sync > google-calendar > evolution2 > vformat > xmlformat > xsltformat Could you check first if any of those still require cmake findmodules? (Maybe there are some which only require FindOpenSync.cmake ...) Doesn't make sense to have a copy of all find-modules in each of those IMHO. Best Regards, Daniel -- Daniel Gollub Geschaeftsfuehrer: Ralph Dehner Linux Consultant & Developer Unternehmenssitz: Vohburg B1 Systems GmbH Amtsgericht: Ingolstadt Mobil: +49-(0)-160 47 73 970 Handelsregister: HRB 3537 EMail: go...@b1... http://www.b1-systems.de Adresse: B1 Systems GmbH, Osterfeldstraße 7, 85088 Vohburg http://pgpkeys.pca.dfn.de/pks/lookup?op=get&search=0xED14B95C2F8CA78D |
|
From: Chris F. <cd...@fo...> - 2010-09-18 07:27:04
|
On Sat, Sep 18, 2010 at 03:02:10PM +1200, Daniel Gollub wrote: > Could you check first if any of those still require cmake findmodules? > (Maybe there are some which only require FindOpenSync.cmake ...) Sure... to check that, I assume I'd remove everything but FindOpenSync.cmake and see if it builds, and if not, add back whatever's missing. I use Debian stable for most of my development. If someone uses something older than that, will they run into problems if we remove everything we don't need, and rely on what comes with cmake? Do we care about that? Thanks, - Chris |
|
From: Björn R. <bjo...@go...> - 2010-09-18 10:54:29
|
Am 18.09.2010 um 05:02 schrieb Daniel Gollub: > Doesn't make sense to have a copy of all find-modules in each of those IMHO. +1 doesn't make sense to me too svn:externals is a nice svn feature and why not using it? |
|
From: Chris F. <cd...@fo...> - 2010-09-18 11:08:27
|
On Sat, Sep 18, 2010 at 12:54:24PM +0200, Bj?rn Ricks wrote: > > Am 18.09.2010 um 05:02 schrieb Daniel Gollub: > > Doesn't make sense to have a copy of all find-modules in each of those IMHO. > > +1 doesn't make sense to me too > > svn:externals is a nice svn feature and why not using it? I think what Daniel meant was: why include all 61 cmake files in every project via svn:externals, when we might only need a few specific ones. But if I misinterpreted, please let me know. - Chris |
|
From: Daniel G. <go...@b1...> - 2010-09-19 00:09:40
|
On Saturday, September 18, 2010 11:08:19 pm you wrote: > > Am 18.09.2010 um 05:02 schrieb Daniel Gollub: > > > Doesn't make sense to have a copy of all find-modules in each of those > > > IMHO. > > > > > > > > +1 doesn't make sense to me too > > > > > > > > svn:externals is a nice svn feature and why not using it? Because it breaks SCM-Bridges (like to git and other SCMs) and people cry ... > > I think what Daniel meant was: why include all 61 cmake files in every > project via svn:externals, when we might only need a few specific ones. No. I thought of "svn cp"-copies or so. Having 61 cmake files in there with svn:external is for me no problem, since it's O(1) to maintain them :P > But if I misinterpreted, please let me know. Just start with the plugins and you're using. Remove svn:externals and create a "svn cp" of those modules which still required by the plugin. I just compared the list of find-modules of the cmake version on my laptop (2.8.1) and the one which is in OpenSync svn: Those are still not in cmake: ---8<--- +++ cmake-osync 2010-09-19 11:45:18.000000000 +1200 +FindBlueZ.cmake (evo2-sync only?) +FindBONOBO2.cmake +FindBONOBOACTIVATION2.cmake (All plugins which use check as testing framework) +FindCheck.cmake (evo2-sync only?) +FindEBook1.0.cmake +FindEBook1.2.cmake +FindECal1.0.cmake +FindECal1.2.cmake +FindEDataBook1.0.cmake +FindEDataBook1.2.cmake +FindEDataCal1.0.cmake +FindEDataCal1.2.cmake +FindEDataServer1.0.cmake +FindEDataServer1.2.cmake +FindEPackage.cmake +FindEvolutionDataServer1.0.cmake +FindEvolutionDataServer1.2.cmake +FindExpat.cmake # libwbxml? +FindGConf2.cmake +FindGLIB2.cmake # libopensync & libsynclm +FindGMODULE2.cmake (gnokii-sync only) +FindGNOKII.cmake +FindGnomeVfs2.cmake +FindGNUTLS.cmake +FindGOBJECT2.cmake # libsyncml +FindGTHREAD2.cmake # libopensync (kdepim-sync only?) +FindKDEPIM3.cmake +FindLibDbus.cmake +FindLibDbusGlib.cmake (required by opensync and xsltformat plugin?) +FindLibExslt.cmake (google-calndar plugin only) +FindLibGcal.cmake +FindLibGCrypt.cmake +FindLibGlade.cmake +FindLibGnome2.cmake +FindLibGSSAPIV2.cmake (ldap-sync only?) +FindLibLdap.cmake +FindLibMozLdap.cmake +FindLibSASL2.cmake (libsyncml only) +FindLibSoup2.cmake (syncml-pluign only) +FindLibSyncMl.cmake +FindLibUuid.cmake (libsyncml and some other ..) +FindLibWbxml2.cmake (irmc-sync and syncml-plugin maybe? or just libsyncml ...) +FindOpenObex.cmake +FindOpenSync.cmake # mandatory for plugins +FindORBit2.cmake (palm-sync only) +FindPilotLink.cmake +FindSqlite3.cmake # libsyncml? libopensync +FindSqlite.cmake (mozilla-sync only?) +FindThunderbirdXpcom.cmake -->8---- (... or maybe the filename differs?) Those found their way into cmake-package: ----8<-- FindGTK2.cmake FindLibXml2.cmake # libopensync and libsyncml FindLibXslt.cmake # libopensync and xsltformat plugin FindPkgConfig.cmake # libopensync FindPythonLibs.cmake # libopensync FindQt4.cmake FindSWIG.cmake # libopensync --->8--- Someone should check if their are compatible to the one in OpenSync ... cmake modules which are not find-modules and might be used be plugins as well: ---8<--- ./AddDocumentation.cmake # not mandatory for plugins ./ShowStatus.cmake # mandatory for plugins ./MacroEnsureOutOfSourceBuild.cmake # recommended ./cmake_uninstall.cmake.in # recommended ./Testing.cmake # not mandatory but helpful for writing unittests ./Compiler.cmake # not mandatory for plugins ---->8-- -- Daniel Gollub Geschaeftsfuehrer: Ralph Dehner Linux Consultant & Developer Unternehmenssitz: Vohburg B1 Systems GmbH Amtsgericht: Ingolstadt Mobil: +49-(0)-160 47 73 970 Handelsregister: HRB 3537 EMail: go...@b1... http://www.b1-systems.de Adresse: B1 Systems GmbH, Osterfeldstraße 7, 85088 Vohburg http://pgpkeys.pca.dfn.de/pks/lookup?op=get&search=0xED14B95C2F8CA78D |