Re: [Opensync-users] Bad call to free() in xml-vcard.c

[Armin B. <arm...@de...>]

Michael Kolmodin wrote:
> Valgrind reveals an illegal call to free() in xml-vcard.c. The ticket
> system does accept my attempt to create a ticket, hangs.

It did hang since i have to use a mail relay to send the mails to
sourceforge mailinglists. But this relay server was down due to a power
loss which lasted longer than the ups :)

> 
> Enclosing patch

Thanks! committed.

Armin

> 
> --------------------------------------------------------------------------
> Michael Kolmodin                        Kungsg 24, 1 tr
> Phone:  +46 920 269413                  S-972 31 Lulea
> Mobile  +46 70 551 6507                 Sweden
> 
> 
> ------------------------------------------------------------------------
> 
> --- ./opensync-org/formats/vformats-xml/xml-vcard.c	2006-03-05 12:51:05.000000000 +0100
> +++ ./opensync/formats/vformats-xml/xml-vcard.c	2006-03-05 12:46:33.000000000 +0100
> @@ -419,7 +419,7 @@
>  		 * This is necessary because some fields (N and ADR, for example) need
>  		 * a specific order of the values
>  		 */
> -		tmp = "";
> +		tmp = g_strdup( "" );
>  	}
>  	
>  	if (needs_charset((unsigned char*)tmp))