From: A. <rem...@ya...> - 2006-01-12 13:26:46
|
Le jeudi 12 janvier 2006 =C3=A0 01:48 +0100, Armin Bauer a =C3=A9crit : > thanks for your help! you are welcome > i can confirm the crash. I added a test case for the vcal parser that > triggers the crash. The problem is that the vformat parser stops parsin= g > at the invalid utf8 input and therefore the resulting object is > different than what opensync expects. i should take a look at the test creation, it will help me provide diff proposals faster :-) >=20 > so there are 3 issues to fix here: >=20 > - the crash. opensync should never ever crash. I think the diff I provide in another message answers to that point. >=20 > - i guess its better if we return an error of the vformat parser cannot > parse the input than trying to return an invalid parsed object... it depends what you think your users want and what are the responsibilities of the plugins. if the plugins is not required to provide valid utf8, I think we have to deal with that problem in opensync. It's what I did in the second diff I provide in that other message. if the plugin is required to provide utf8 (and I think it is valid to require that from a plugin developper), the parser should return an error if the input is not valid. > - add support for encodings besides utf8. this is a big item on my todo > list. internally opensync handles everything as utf8. but then we need = a > parameter which specifies which encoding the input/output is. support to help plugin developper dealing with the utf8 transformation, yes, I agree. I think it would be an error to put too many things in the engine itself. For me, there is a clear separation in term of roles between plugin and engine. 1) the engine ensures communication between plugins and provides the common format used to communicate 2) the plugin is in charge of the access to the terminal (evo2, phone, etc) and it is in charge of the necessary transformation of the data between terminal and engine. So, which part should be in charge of the charset translation ? :-) RemyA --=20 E-mail : Rem...@ya... Yahoo Architecture Europe (http://www.yahoo.com/) Yahoo Id: kelkooremya |