Re: [Opensync-devel] file-sync patches

[Mark E. <ma...@mp...>]

On Fri, 2013-09-13 at 19:49 +0200, Chris Frey wrote:
> On Tue, Aug 27, 2013 at 10:32:32PM +0100, Graham Cobb wrote:
> > If we need a reversible mapping then let's just agree on the
> > reserved_chars_allowed list to provide to g_uri_escape_string so that
> > special characters don't get turned into hex codes unnecessarily.
> > 
> > I suggest using " #$&(),?!@'".  They are all characters that appear
> > fairly often in subject lines of meetings or in names (both of which
> > often get used in file names for file-sync).
> 
> Is there concensus in the form of a patch that I need to apply yet? :-)
> 
> No rush, just checking.  I don't want to be the one holding up production.
> 

Hi Chris

Actually, I was thinking about what Graham said initially, and it's left
me in a dilemma.

The encoding needs to be reversible, no doubt about that, and uri %
encoding is nice and easy and recognisable, so I'm happy with that.

Using the glib function, with Graham's additional allowed characters, is
nice, easy, quick and safe, but as Graham said, does limit users in what
they can call new files they want to sync. I've written an alternative
which only escapes %/:*\\>< but it assumes everything is utf8 and/or
ascii.

So my response is, would we rather have something easy with a bit less
functionality, or more functionality with built in assumptions that
might have unforeseen consequences ?

Mark